Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am getting "Support for defaultProps" warning for every icon that i am using. #86

Open
saleh-b opened this issue Nov 24, 2023 · 5 comments
Open

I am getting "Support for defaultProps" warning for every icon that i am using. #86

saleh-b opened this issue Nov 24, 2023 · 5 comments

Comments

@saleh-b
Copy link

saleh-b commented Nov 24, 2023 •
edited
Loading

Warning: UilTimesSquare: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

How do I deal with this?
@DannyCarvajal
Copy link

+1

2 similar comments
@larrysingh
Copy link

+1

@fadichmn
Copy link

+1

@doniek
Copy link

doniek commented Jun 18, 2024

This issue is open for quite some time and as far as I can see it seems like a simple fix in the build/generate.js to default the color and size in the method header. I'm not familiar with this library and the way it is build, so would be great if one of the maintainers can actually change the behavior to remove the deprecated use of defaultprops.

fnogatz added a commit to SUSIandJames/react-unicons that referenced this issue Jul 10, 2024
@fnogatz
Use ES6 default properties instead of deprecated defaultProps property
5d932fe 
Fixes Iconscout#86 and Iconscout#64

The work on this PR was sponsored by [SUSI&James GmbH](https://susiandjames.com/)
This was referenced Jul 10, 2024
Open
Merged
@fnogatz
Copy link

fnogatz commented Jul 10, 2024

I created PR #95 which addresses this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fnogatz @fadichmn @larrysingh @doniek @DannyCarvajal @saleh-b