Spi slave enablement #128
Merged
Spi slave enablement #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
3 times, most recently
from
991f97d
to
7efa045
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
5 times, most recently
from
73bf02e
to
c4336ad
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
3 times, most recently
from
0e77323
to
185aa69
Compare
NikhitaR-IFX
force-pushed
the
spi-slave-enablement
branch
from
e477eaa
to
236f1dd
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
from
185aa69
to
22bdaad
Compare
NikhitaR-IFX
force-pushed
the
spi-slave-enablement
branch
from
a321ecb
to
41179fe
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
2 times, most recently
from
c063245
to
1c4b6c1
Compare
jaenrig-ifx
force-pushed
the
spi-slave-enablement
branch
2 times, most recently
from
4f1da80
to
3a70d83
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
4 times, most recently
from
67f9037
to
8149c71
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
3 times, most recently
from
d822a4a
to
d5a9b1b
Compare
NikhitaR-IFX
force-pushed
the
spi-slave-enablement
branch
from
3a70d83
to
b446abe
Compare
jaenrig-ifx
force-pushed
the
ports-psoc6-main
branch
from
d5a9b1b
to
bb49844
Compare
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
NikhitaR-IFX
force-pushed
the
spi-slave-enablement
branch
from
0a64bd9
to
b84e71c
Compare
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
jaenrig-ifx
reviewed
Jun 20, 2024
| ./psoc6/run_psoc6_tests.sh -c --psoc6-hwext --dev0 ${devs0[0]} | ||
| ./psoc6/run_psoc6_tests.sh -c --psoc6-hwext --dev0 ${devs0[0]} | ||
| echo " >> PSoC6 i2c tests" | ||
| if [ "${{ matrix.board }}" == "CY8CPROTO-062-4343W" ]; then |
There was a problem hiding this comment.
By the way, this dirty selection approach (sorry for that 😞) should be tackle in the rework of this run_psoc6_tests.sh in future. I might have the chance to start as pre-1.0.0.
ports/psoc6/machine_spi.c
Outdated
| } | ||
|
|
||
| mp_obj_t machine_spi_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args) { | ||
| enum { ARG_id, ARG_baudrate, ARG_polarity, ARG_phase, ARG_bits, ARG_firstbit, ARG_sck, ARG_mosi, ARG_miso }; | ||
| mp_obj_t machine_spi_master_init_helper(machine_spi_obj_t *self, size_t n_args, size_t n_kw, const mp_obj_t *all_args) { |
There was a problem hiding this comment.
Mmm, do we really need two machine_spi_xxxx_init_helpers()? We had one only before, no?
Can we just not have one? and if the user pass the ssel for master complain, and if he does not pass it for slave also complain?
Other than that parameter, the rest is the same or?
IFX-Anusha
approved these changes
Jun 21, 2024
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
jaenrig-ifx
force-pushed
the
spi-slave-enablement
branch
from
e5d5c3d
to
61a6ad2
Compare
|
@ramya-subramanyam we are going to merge to bring latest HIL changes to main. You can review later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description:
SPISLave enabled with following functions:
Constructor
deinit()
write()
read()
write_readinto()
Hardware tests extended for SPI module
Documents corrected with latest changes
Pin connections for HIL test setup updated
SoftSPI feature discarded as it is not working as expected.
Removed old spi tests just calling the constructor.
Other not on ports/psoc6/spi code changes:
@jaenrig-ifx @IFX-Anusha @ramya-subramanyam : This PR is now ready to review.