Machine spi deinit #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
NikhitaR-IFX
approved these changes
Oct 17, 2023
| @@ -183,6 +184,7 @@ void mpy_task(void *arg) { | |||
| mod_adc_block_deinit(); | |||
| mod_i2c_deinit(); | |||
| mod_pwm_deinit(); | |||
| mod_spi_deinit(); | |||
| mod_pin_phy_deinit(); | |||
There was a problem hiding this comment.
I have the same concern here. If mod_spi_deinit ihas already deinited the physical pin, then what consequences would mod_pin_phy_deinit has if internally it is not checking a deinit operation was already done from module side.
There was a problem hiding this comment.
As before, that pin_phy_deinit() can be called several times without unexpected behavior, if deinited already, then it has no unsafe effect.
IFX-Anusha
approved these changes
Oct 17, 2023
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
To be reviewed after #97.
Added deinit functions and refactoring for pin_phy changes.