Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from commonjs to esm project #361

Closed
lyricnz opened this issue Jun 16, 2024 · 2 comments
Closed

Update from commonjs to esm project #361

lyricnz opened this issue Jun 16, 2024 · 2 comments
Labels
low-priority

Comments

@lyricnz
Copy link
Contributor

lyricnz commented Jun 16, 2024

I expect more and more modules will have this as a requirement (eg: chai 5.x, chai-as-promised 8.x)

However it looks like making this change would require making all imports to have explicit .js suffix, which is kindof gross.

https://mikebian.co/converting-a-node-project-from-commonjs-to-esm/

eg chaijs/chai-as-promised#301
@lyricnz lyricnz mentioned this issue Jun 16, 2024
Merged
@lyricnz
Copy link
Contributor Author

lyricnz commented Jun 18, 2024

Why? https://electerious.medium.com/from-commonjs-to-es-modules-how-to-modernize-your-node-js-app-ad8cdd4fb662

@lyricnz
Copy link
Contributor Author

lyricnz commented Jun 18, 2024

Ugly, but forward-looking PR merged.

@lyricnz lyricnz closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lyricnz