Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests by using the ITK testing macros. #70

Open
jhlegarreta opened this issue Nov 9, 2018 · 2 comments
Open

Improve tests by using the ITK testing macros. #70

jhlegarreta opened this issue Nov 9, 2018 · 2 comments

Comments

@jhlegarreta
Copy link
Member

The existing tests should be improved:

  • The ITK testing macros should be used (e.g. TRY_EXPECT_NO_EXCEPTION, EXERCISE_BASIC_OBJECT_METHODS, etc.) to avoid boilerplate code.
@jhlegarreta
Copy link
Member Author

Good First Issue

@dzenanz
Copy link
Member

dzenanz commented Nov 9, 2018

The added tests could go here.

dzenanz added a commit to dzenanz/ITKMontage that referenced this issue Oct 14, 2019
Also enable pair-wise test for all ground truth tests.

Summary results (below) suggest presence of bias in sub-pixel peak estimation:

PeakInterpolation 0 has average translation bias: -0.040 -0.028
PeakInterpolation 1 has average translation bias: -0.035 -0.025
PeakInterpolation 2 has average translation bias: -0.038 -0.027
Average translation error for padding method 2: 0.194
Test InsightSoftwareConsortium#52: itkMontageGroundTruthRun10-129 ..............***Failed    2.33 sec

PeakInterpolation 0 has average translation bias: -0.011 -0.017
PeakInterpolation 1 has average translation bias: -0.009 -0.014
PeakInterpolation 2 has average translation bias: -0.010 -0.016
Average translation error for padding method 2: 0.162
Test InsightSoftwareConsortium#54: itkMontageGroundTruthRunrun2 ................   Passed    1.58 sec

PeakInterpolation 0 has average translation bias: 0.021 -0.010
PeakInterpolation 1 has average translation bias: 0.019 -0.009
PeakInterpolation 2 has average translation bias: 0.020 -0.010
Average translation error for padding method 2: 0.172
Test InsightSoftwareConsortium#56: itkMontageGroundTruthRunMediumCarbonSteel ...***Failed    3.49 sec

PeakInterpolation 0 has average translation bias: 0.104 0.303 -0.040
PeakInterpolation 1 has average translation bias: 0.104 0.302 -0.041
PeakInterpolation 2 has average translation bias: 0.104 0.303 -0.041
Average translation error for padding method 2: 0.306
Test InsightSoftwareConsortium#70: itkMontageGroundTruthRunDzZ_T1 ..............***Failed   19.56 sec

PeakInterpolation 0 has average translation bias: 1.065 1.733
PeakInterpolation 1 has average translation bias: 1.066 1.734
PeakInterpolation 2 has average translation bias: 1.065 1.733
Average translation error for padding method 2: 1.811
Test InsightSoftwareConsortium#79: itkMontageGroundTruthRunTiles ...............***Failed   10.31 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants