Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - estimateTransactionKeyWitnessCount doesn't appear to consider native (simple) scripts #551

Open
sourabhxyz opened this issue Jun 11, 2024 · 6 comments

Comments

@sourabhxyz
Copy link

Internal/External
External

Area
Transaction building

Summary

For transactions making use of native scripts, the required number of key witness may be more than what is returned by estimateTransactionKeyWitnessCount as it doesn't consider them (native scripts). Fwiw, the key witnesses required by native script are taken from transaction_witness_set (see attached image from Shelley ledger specification) and thus the required signatories mentioned by these scripts need not have any mention in transaction_body.

image

Wrong estimate by estimateTransactionKeyWitnessCount leads to wrong estimate of required transaction fees when building the transaction using cardano-api's makeTransactionBodyAutoBalance unless one gives appropriate key witness estimate to it.

@carbolymer
Copy link
Contributor

cc: @Jimbo4350

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Aug 22, 2024
@smelc smelc removed the Stale label Aug 22, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants