Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug *-poll legacy commands back #340

Closed
smelc opened this issue Oct 5, 2023 · 1 comment · Fixed by #349
Closed

Plug *-poll legacy commands back #340

smelc opened this issue Oct 5, 2023 · 1 comment · Fixed by #349
Assignees
@smelc
Labels
bug Something isn't working enhancement New feature or request

Comments

@smelc
Copy link
Contributor

smelc commented Oct 5, 2023

Actually, an oversight in my review. We're not actually supposed to delete the legacy commands. These need to be kept in tact. We will eventually delete all the legacy commands in one go, but not right now.

Originally posted by @newhoggy in #322 (comment)
@smelc smelc self-assigned this Oct 5, 2023
@smelc smelc added bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@smelc
Copy link
Contributor Author

smelc commented Oct 5, 2023 •
edited
Loading

From https://github.com/input-output-hk/cardano-cli/pull/322/files#diff-9aa8507a4f21a0da4260f999c8af9a47a275c6bfae9b83464855666c5b2e05a8:

image

@smelc smelc mentioned this issue Oct 9, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smelc smelc

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plug *-poll legacy commands back IntersectMBO/cardano-cli
1 participant
@smelc