Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant voting and proposal procedures functions. Update cardano-api. #856

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 1, 2024

Changelog

- description: |
    Remove redundant voting and proposal procedures functions.
    Update cardano-api-9.2.0.0.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR is stacked on top of:

This PR should be reviewed on commit-by-commit basis.

This PR introduces additional minor refactoring:

  • Replace usage of L.Coin with Lovelace type alias and a pattern synonym
  • Replace usages of ListMap.toList and ListMap.fromList with IsList(toList, fromList).

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch 3 times, most recently from d08e6af to 6d041a8 Compare August 8, 2024 08:11
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch 11 times, most recently from 574a53b to 56a2cb7 Compare August 13, 2024 11:23
@carbolymer carbolymer changed the title Remove redundant voting and proposal procedures functions Remove redundant voting and proposal procedures functions. Update cardano-api. Aug 13, 2024
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch 2 times, most recently from 0b13a03 to 7e4d068 Compare August 13, 2024 11:49
@carbolymer carbolymer marked this pull request as ready for review August 13, 2024 11:53
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch from 7e4d068 to f44a671 Compare August 13, 2024 11:58
cardano-cli/src/Cardano/CLI/EraBased/Run/Transaction.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Json/Friendly.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Json/Friendly.hs Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch from f44a671 to e77854e Compare August 14, 2024 13:47
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch from e77854e to d016584 Compare August 14, 2024 13:47
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch from d016584 to 9403f26 Compare August 14, 2024 14:05
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's just use the Coin constructor.

cardano-cli/src/Cardano/CLI/Types/Common.hs Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-redundant-voting-proposal-functions branch from 9403f26 to 1935756 Compare August 15, 2024 06:43
@carbolymer carbolymer merged commit 64e86e7 into main Aug 15, 2024
24 of 25 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/remove-redundant-voting-proposal-functions branch August 15, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants