-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant voting and proposal procedures functions. Update cardano-api. #856
Merged
carbolymer
merged 3 commits into
main
from
mgalazyn/fix/remove-redundant-voting-proposal-functions
Aug 15, 2024
Merged
Remove redundant voting and proposal procedures functions. Update cardano-api. #856
carbolymer
merged 3 commits into
main
from
mgalazyn/fix/remove-redundant-voting-proposal-functions
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
3 times, most recently
from
August 8, 2024 08:11
d08e6af
to
6d041a8
Compare
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
11 times, most recently
from
August 13, 2024 11:23
574a53b
to
56a2cb7
Compare
carbolymer
changed the title
Remove redundant voting and proposal procedures functions
Remove redundant voting and proposal procedures functions. Update cardano-api.
Aug 13, 2024
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
2 times, most recently
from
August 13, 2024 11:49
0b13a03
to
7e4d068
Compare
carbolymer
requested review from
a team,
Jimbo4350,
newhoggy,
smelc,
palas,
kevinhammond and
disassembler
as code owners
August 13, 2024 11:53
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
from
August 13, 2024 11:58
7e4d068
to
f44a671
Compare
smelc
reviewed
Aug 14, 2024
smelc
approved these changes
Aug 14, 2024
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
from
August 14, 2024 13:47
f44a671
to
e77854e
Compare
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
from
August 14, 2024 13:47
e77854e
to
d016584
Compare
3 tasks
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
from
August 14, 2024 14:05
d016584
to
9403f26
Compare
Jimbo4350
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's just use the Coin
constructor.
carbolymer
force-pushed
the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
from
August 15, 2024 06:43
9403f26
to
1935756
Compare
carbolymer
deleted the
mgalazyn/fix/remove-redundant-voting-proposal-functions
branch
August 15, 2024 08:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR is stacked on top of:
IsList(toList,fromList)
instead of specialised functions #865This PR should be reviewed on commit-by-commit basis.
This PR introduces additional minor refactoring:
L.Coin
withLovelace
type alias and a pattern synonymListMap.toList
andListMap.fromList
withIsList(toList, fromList)
.Checklist