Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show diff on failure in cabal-gild check action #857

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Show diff on failure in cabal-gild check action #857

merged 2 commits into from
Aug 5, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Aug 2, 2024 •
edited
Loading

Changelog

- description: |
    Added diff to output of cardano-gild check action
  type:
  - test           # fixes/modifies tests

Context

It is nice to know what is wrong specifically with the formatting when CI fails, so this PR modifies the cardano-gild action to show a diff when it fails.

I am also using the opportunity to fix a wrong variable name.

Related PR on cardano-api: IntersectMBO/cardano-api#605

How to trust this PR

This is what happens when format check fails: Failed run

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Aug 2, 2024
@palas palas self-assigned this Aug 2, 2024
@palas palas changed the title Fix cabal gild issues Show diff on failure in cabal-gild check action Aug 2, 2024
@palas palas mentioned this pull request Aug 2, 2024
Merged
3 tasks
Jimbo4350
Jimbo4350 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but also echo the required version of cabal-gild.

@palas palas enabled auto-merge August 5, 2024 16:02
@palas palas added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 5, 2024
@palas palas added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 0e2afa6 Aug 5, 2024
23 checks passed
@palas palas deleted the fix-cabal-gild-issues branch August 5, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palas @carbolymer @Jimbo4350