SL-196: payment method invoice append #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mant02
commented
Dec 8, 2023
mant02
commented
mandan2
reviewed
Dec 8, 2023
saferpayofficial.php
Outdated
| @@ -21,6 +21,8 @@ | |||
| *@license SIX Payment Services | |||
| */ | |||
|
|
|||
| use Invertus\SaferPay\Repository\SaferPayOrderRepository; | |||
There was a problem hiding this comment.
If module is supported in 1.6, then do not use dependency import here in main class. If you need to define service namespace, use full namespace where you need that (probably other services are use there like that as well).
mandan2
reviewed
Dec 8, 2023
| public function hookActionObjectOrderPaymentAddAfter($params) | ||
| { | ||
| /** @var OrderPayment $orderPayment */ | ||
| $orderPayment = $params['object']; |
There was a problem hiding this comment.
check if this is valid object as well, also check if array key is actually set
mandan2
reviewed
Dec 8, 2023
| $orders = Order::getByReference($orderPayment->order_reference); | ||
|
|
||
| /** @var Order $order */ | ||
| $order = $orders->getFirst(); |
There was a problem hiding this comment.
can also be bool (not sure what in 1.6 is return value). Order|bool
mandan2
reviewed
Dec 8, 2023
saferpayofficial.php
Outdated
| return; | ||
| } | ||
|
|
||
| // NOTE: ask on what to name the payment method. Ex. SaferPay - PayPal ... |
mandan2
reviewed
Dec 8, 2023
saferpayofficial.php
Outdated
| return; | ||
| } | ||
|
|
||
| $brand = $saferPayOrderRepository->getPaymentBrandByAssertId($saferPayAssertId); |
There was a problem hiding this comment.
useless method, just retrieve brand by safer pay order id and replace method above
Base automatically changed from
SL-192-new-description-field
to
release_1_1_8
December 12, 2023 09:28
mandan2
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.