Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SL-203: match shop language with iframe #135

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

mant02
Copy link
Contributor

@mant02 mant02 commented Dec 8, 2023

Previously the LanguageCode was not being set, so the hosted iframe would always be set to default lang

image

@@ -68,6 +69,7 @@ public function create(
$totalPrice = (int) (round($totalPrice));
$payment = $this->requestObjectCreator->createPayment($cart, $totalPrice);
$payer = new Payer();
$payer->setLanguageCode($cart->getAssociatedLanguage()->iso_code);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible that language is deleted and this would throw an error

Base automatically changed from SL-196-payment-method-invoice-append to release_1_1_8 December 12, 2023 11:17
@mant02 mant02 merged commit 6f851d1 into release_1_1_8 Dec 12, 2023
@mant02 mant02 deleted the SL-203-match-shop-language-with-iframe branch December 12, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants