Iris Shaders breaking Distant Horizon Fog

[Borous]

What happened?

For a good while now Distant Horizons has had an issue wherin if loaded with Iris shaders, without actively using shaders, the fog of DH breaks. Although it was initially believed to be an issue with DH itself, the devs thereof have seemingly concluded that the issue appears to be caused by Iris itself.

This issue persists in both stable and experimental builds of DH when paired with any compatible Iris vers

Attached below are two screenshots that indicate what it looks like when the specifically DH unique fog isnt working.

Screenshots

Log output

No response

Minecraft Version

1.21.1

Iris Version

iris-1.8.1+mc1.21.1.jar

Operating System

Windows 10

What is your GPU?

AMD Radeon RX 7800 XT

Additional context

No response

[Steveplays28]

I think shouldOverride should be set to false before the return statement in DHCompatInternal:

Iris/common/src/main/java/net/irisshaders/iris/compat/dh/DHCompatInternal.java

Lines 55 to 59 in d2038d1

	if (pipeline.getDHTerrainShader().isEmpty() && pipeline.getDHWaterShader().isEmpty()) {
	Iris.logger.warn("No DH shader found in this pack.");
	incompatible = true;
	return;
	}

shouldOverride determines if DH's fog is enabled or disabled in LodRenderEvents:

Iris/common/src/main/java/net/irisshaders/iris/compat/dh/LodRendererEvents.java

Line 90 in d2038d1

DhApi.Delayed.configs.graphics().fog().drawMode().setValue(getInstance().shouldOverride ? EDhApiFogDrawMode.FOG_DISABLED : EDhApiFogDrawMode.FOG_ENABLED);

I haven't tested this so it might be wrong.

EDIT: shouldOverride does get set to false when clear() is called. Maybe this isn't the correct fix.

EDIT 2: There should be another check for Iris.isPackInUseQuick() to determine if the fog is drawn, similar to the line above the fog override.

EDIT 3: This section shouldn't also touch the fog draw mode, with the above changes:

Iris/common/src/main/java/net/irisshaders/iris/compat/dh/LodRendererEvents.java

Lines 270 to 281 in 5af944d

	// config overrides
	if (instance.shouldOverride) {
	DhApi.Delayed.configs.graphics().ambientOcclusion().enabled().setValue(false);
	DhApi.Delayed.configs.graphics().fog().drawMode().setValue(EDhApiFogDrawMode.FOG_DISABLED);
	if (event.value.renderPass == EDhApiRenderPass.OPAQUE_AND_TRANSPARENT) {
	Iris.logger.error("Unexpected; somehow the Opaque + Translucent pass ran with shaders on.");
	}
	} else {
	DhApi.Delayed.configs.graphics().ambientOcclusion().enabled().clearValue();
	DhApi.Delayed.configs.graphics().fog().drawMode().clearValue();
	}