Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading indicator on initial load #3

Closed
pandurijal opened this issue Sep 30, 2020 · 11 comments
Closed

Add loading indicator on initial load #3

pandurijal opened this issue Sep 30, 2020 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest2020 help wanted Extra attention is needed

Comments

@pandurijal
Copy link

pandurijal commented Sep 30, 2020 •
edited
Loading

Hey, at first I thought the app is broken, but I realized it's just because there are no loading indicators on the initial load. Can I work on this issue?

Screenshot 2020-10-01 at 00 54 48
@pssingh21
Copy link

Hi. I would like to contribute to this. Happy Hacking!

@Ishaan28malik
Copy link
Owner

@pandurijal sure that's actually a really good idea about adding a loader, go-ahead

@Ishaan28malik Ishaan28malik added enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest2020 help wanted Extra attention is needed labels Oct 1, 2020
@Ishaan28malik Ishaan28malik pinned this issue Oct 1, 2020
@pandurijal pandurijal removed their assignment Oct 2, 2020
@Satyam1203
Copy link
Contributor

@pandurijal removed his assignment, and if nobody is doing this, I would like to work on it... @Ishaan28malik

@Ishaan28malik
Copy link
Owner

@Satyam1203 sure.

@Satyam1203
Copy link
Contributor

Hey @Ishaan28malik , wanted to know that should I remove node modules directory or not. It is not preferred I guess but I saw you rejected few PRs that removed it... Should I remove it or not ?

@Ishaan28malik
Copy link
Owner

Hey @Ishaan28malik , wanted to know that should I remove node modules directory or not. It is not preferred I guess but I saw you rejected few PRs that removed it... Should I remove it or not ?

I am currently working on something , don't delete it for a while

@Satyam1203
Copy link
Contributor

Okay.. Can I change class component to functional component ?
@Ishaan28malik

@Satyam1203
Copy link
Contributor

I forked the repo and just saw that someone already added a loader...

@Ishaan28malik
Copy link
Owner

I forked the repo and just saw that someone already added a loader...

It's not actually the permanent loader you can update with your enhancements and I will check. Implement that and raise a PR

@Satyam1203
Copy link
Contributor

Sure @Ishaan28malik

@Satyam1203 Satyam1203 mentioned this issue Oct 4, 2020
Merged
@Satyam1203
Copy link
Contributor

I've implemented the required changes in PR #19 . Do have alook @Ishaan28malik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest2020 help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pandurijal @Ishaan28malik @pssingh21 @Satyam1203