Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It crashes application if you unsubscribe before connection is establish #37

Open
JustTrust opened this issue Apr 10, 2018 · 4 comments
Open

It crashes application if you unsubscribe before connection is establish #37

JustTrust opened this issue Apr 10, 2018 · 4 comments

Comments

@JustTrust
Copy link

In observeConnectDevice method you need to check if emitter is not disposed before send error or onNext. Please change this code emitter.onError(e) to next if (emitter.isDisposed.not()) emitter.onError(e)
@JustTrust
Copy link
Author

@IvBaranov are you still support this library?

@IvBaranov
Copy link
Owner

Sure, just don't have enough time right now.

@JustTrust
Copy link
Author

Thanks in advance, we will wait for updates )

@radoslawlatka
Copy link

Instead of using if (emitter.isDisposed.not()) you can use just emtter.tryOnError(e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IvBaranov @radoslawlatka @JustTrust