Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with a crash handling library #18

Open
t-artikov opened this issue Mar 28, 2017 · 2 comments
Open

Integration with a crash handling library #18

t-artikov opened this issue Mar 28, 2017 · 2 comments

Comments

@t-artikov
Copy link

NanoLog does not contain crash handling code. I think this is the right decision, as it is the task of a crash handling library. But it would be nice if NanoLog had a function that can be called when a crash happened to be sure that all log messages were written. Something like:

CrashHandling::setCrashCallback([] {
    nanolog::flush();
});
@Iyengar111
Copy link
Owner

Hi,

Sorry for the extremely delayed reply. I don't seem to be getting emails about new updates on this repository!!.

I like your idea. If you don't mind and have the time, could you raise a pull request and I will review and merge it.

If not, I'll pick it up sometime when I get the inspiration :)

Thanks,

Karthik Iyengar

@t-artikov
Copy link
Author

Hi,
I'm afraid I will not implement it properly by myself.
But I'll be glad to try NanoLog as a logging library if it has this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants