Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdf5, netcdf-c, netcdf-fortran #453

Closed
climbfuji opened this issue Jan 23, 2023 · 13 comments
Closed

Update hdf5, netcdf-c, netcdf-fortran #453

climbfuji opened this issue Jan 23, 2023 · 13 comments
Assignees

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Jan 23, 2023

Please describe the package or library you would like to add to spack-stack.
hdf5 1.14.0 was released, we should test this version and switch if we can. See also NOAA-EMC/hpc-stack#513.

For netCDF: netcdf-c is now at 4.9.0 (4.9.1 will be release shortly, should we wait for this one?), netcdf-fortran at 4.6.0, netcdf-cxx4 is at 4.3.1 (but I think we don't want to use netcdf-cxx4 anyway).

What applications will be using this package or library?
All

Is there already a package or library in spack-stack that provides this, or related, functionality?
Earlier versions are used everywhere.

Additional context
n/a

Will This Package be Needed in a NOAA Operational Application?
Those libraries have all been approved on WCOSS2.

@climbfuji climbfuji changed the title Update hdf5, netcdf-c, netcdf-fortran etc (wait for netcdf-c-4.9.1) Update hdf5, netcdf-c, netcdf-fortran etc (wait for netcdf-c-4.9.1?) Feb 1, 2023
@climbfuji
Copy link
Collaborator Author

Update: netcdf-c 4.9.1 currently doesn't compile with hdf5 1.14.0, but netcdf-c 4.9.0 does. This is the problem: Unidata/netcdf-c#2614

Let's hold off on updating to 4.9.1 until the netcdf-c developers fixed this.

@edwardhartnett
Copy link
Collaborator

I don't think you should hold off.

The problem is with byterange code, and we never use it. In fact, we need to build with --disable-byterange anyway, so that disables the code with the bug.

Meanwhile 4.9.1 contains some important fixes for the new quantize and zstd compression features, which the UFS teams wants to try out, and which will also benefit anyone at NCAR who's trying to use these new compression features.

@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA See here. I don't agree, we probably want to build with byterange as soon as the fix has been released (4.9.2) on all platforms EXCEPT the FISMA high systems where we turn it off, together with other things.

@Hang-Lei-NOAA
Copy link
Collaborator

Hang-Lei-NOAA commented Feb 13, 2023 via email

@climbfuji
Copy link
Collaborator Author

climbfuji commented Feb 13, 2023 via email

@Hang-Lei-NOAA
Copy link
Collaborator

Hang-Lei-NOAA commented Feb 13, 2023 via email

@edwardhartnett
Copy link
Collaborator

Can we have more detail about the failure posted here?

@climbfuji
Copy link
Collaborator Author

In the meanwhile, I am going to revert netcdf-c back to 4.9.0 in the first unified-dev PR (#455) or I will never be able to complete that step.

@Hang-Lei-NOAA
Copy link
Collaborator

Hang-Lei-NOAA commented Feb 13, 2023 via email

@Hang-Lei-NOAA
Copy link
Collaborator

Hang-Lei-NOAA commented Feb 13, 2023 via email

@Hang-Lei-NOAA
Copy link
Collaborator

Hang-Lei-NOAA commented Feb 13, 2023 via email

@edward
Copy link

edward commented Feb 13, 2023

Hello @Hang-Lei-NOAA !

I think you meant @edwardhartnett but thanks for making me aware of all the cool stuff NOAA is up to on GitHub! I was involved with getting the Canadian feds into using GitHub so am happy to see more like it.

@climbfuji climbfuji changed the title Update hdf5, netcdf-c, netcdf-fortran etc (wait for netcdf-c-4.9.1?) Update hdf5, netcdf-c, netcdf-fortran Feb 23, 2023
@climbfuji
Copy link
Collaborator Author

This update was completed in #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants