Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate and leading zeroes #38

Open
JCumin opened this issue Jan 5, 2017 · 1 comment
Open

Concatenate and leading zeroes #38

JCumin opened this issue Jan 5, 2017 · 1 comment

Comments

@JCumin
Copy link
Owner

JCumin commented Jan 5, 2017

If all elements of the input list are bound, we should relax the constraint that there cannot be any leading zero.
If they are not all bound, then the behavior stays the same as before (to avoid infinite choice points).

This was brought up by @ais523 in this PPCG comment

@JCumin
Copy link
Owner Author

JCumin commented Jun 13, 2017

This commit solves this problem ONLY IF the input is ground and the output is a variable (which is typically when the problem occurs).

It still doesn't work properly when both the input and the output are ground. Concatenate's implementation is really messy and that's hard to implement without breaking everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant