Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component functionality to separate modules #31

Open
calebbraun opened this issue Nov 20, 2018 · 1 comment
Open

Refactor component functionality to separate modules #31

calebbraun opened this issue Nov 20, 2018 · 1 comment
Labels
quality Issues related to code quality, but not affecting correctness or performance

Comments

@calebbraun
Copy link
Contributor

As we add more classes to components.py, the file may get too long.

It would be better to refactor the classes (or at least the long ones) so that the main functionality is implemented in a separate python module for each component, with the class derived from ComponentBase providing a thin wrapper that grabs inputs needed from other components and passes them to a main function in the relevant python component.

@rplzzz
Copy link
Contributor

rplzzz commented Nov 20, 2018

We definitely need this.

@rplzzz rplzzz added enhancement quality Issues related to code quality, but not affecting correctness or performance and removed enhancement labels Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Issues related to code quality, but not affecting correctness or performance
Projects
None yet
Development

No branches or pull requests

2 participants