Skip to content

Commit

Permalink
download settings controls during 'setup native'
Browse files Browse the repository at this point in the history
e-mission/e-mission-docs#958

Because we bundle all the JS with Webpack now, we need to download the settings control upfront. We can add an npm script that does this and call it during setup_shared_native.sh (because it will be needed for both iOS and android platforms).
  • Loading branch information
JGreenlee committed Aug 23, 2023
1 parent 9579012 commit ab10c44
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions package.cordovabuild.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"url": "git+https://github.com/e-mission/e-mission-phone.git"
},
"scripts": {
"setup-native": "./bin/download_settings_controls.js",
"build": "npx webpack --config webpack.prod.js && npx cordova build",
"build-dev": "npx webpack --config webpack.dev.js && npx cordova build",
"build-dev-android": "npx webpack --config webpack.dev.js && npx cordova build android",
Expand Down
2 changes: 2 additions & 0 deletions setup/setup_shared_native.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ cp setup/google-services.fake.for_ci.json google-services.json
echo "Setting up all npm packages"
npm install

npm run setup-native

# By default, node doesn't fail if any of the steps fail. This makes it hard to
# use in a CI environment, and leads to people reporting the node error rather
# than the underlying error. One solution is to pass in a command line argument to node
Expand Down

0 comments on commit ab10c44

Please sign in to comment.