Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use top-level config as fallback when using monitor-based config #373

Merged
merged 1 commit into from
Dec 11, 2023

feat: use top-level config as fallback when using monitor-based config

659c93d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: use top-level config as fallback when using monitor-based config #373

feat: use top-level config as fallback when using monitor-based config
659c93d
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Dec 10, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 88 in src/modules/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `new` is never used

warning: associated function `new` is never used
  --> src/modules/mod.rs:88:8
   |
87 | impl<W: IsA<Widget>> ModuleParts<W> {
   | ----------------------------------- associated function in this implementation
88 |     fn new(widget: W, popup: Option<ModulePopupParts>) -> Self {
   |        ^^^

Check warning on line 14 in src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

constant `ERR_WAYLAND_DATA` is never used

warning: constant `ERR_WAYLAND_DATA` is never used
  --> src/error.rs:14:11
   |
14 | pub const ERR_WAYLAND_DATA: &str = "Failed to get data for Wayland object";
   |           ^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 231 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> src/main.rs:231:9
    |
231 |     let mut config = env::var("IRONBAR_CONFIG")
    |         ----^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 20 in src/clients/wayland/wl_seat.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `qh`

warning: unused variable: `qh`
  --> src/clients/wayland/wl_seat.rs:20:9
   |
20 |         qh: &QueueHandle<Self>,
   |         ^^ help: if this is intentional, prefix it with an underscore: `_qh`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 24 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `lazy_static::lazy_static`

warning: unused import: `lazy_static::lazy_static`
  --> src/main.rs:24:5
   |
24 | use lazy_static::lazy_static;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default