From 5a36c1838d4a98bcbf4b5b80679f7532781af965 Mon Sep 17 00:00:00 2001 From: jp Date: Sat, 30 Mar 2024 12:08:09 +0100 Subject: [PATCH 1/2] feat: added analyst report, adjustment in tests --- .github/workflows/pytests.yml | 2 +- etfpy/client/etf_client.py | 3 --- tests/test_etf_client.py | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pytests.yml b/.github/workflows/pytests.yml index d4fab42..8ace7d7 100644 --- a/.github/workflows/pytests.yml +++ b/.github/workflows/pytests.yml @@ -34,7 +34,7 @@ jobs: run: | source .venv/bin/activate pip install requests - pytest --cov=./ --cov-report=xml -vv -ss + pytest --cov=./ --cov-report=xml -vv -ss -k "not test_functional" echo "tests finished" - name: Upload coverage to Codecov uses: codecov/codecov-action@v3 diff --git a/etfpy/client/etf_client.py b/etfpy/client/etf_client.py index 2bd2b5c..e101dae 100644 --- a/etfpy/client/etf_client.py +++ b/etfpy/client/etf_client.py @@ -290,7 +290,4 @@ def _basic_info(self) -> Dict: basic_information.update(self._trading_data()) basic_information.update(self._asset_categories()) basic_information.update(self._factset_classification()) - if "Analyst Report" in basic_information: - basic_information.pop("Analyst Report") - return basic_information diff --git a/tests/test_etf_client.py b/tests/test_etf_client.py index 1f94f9a..8147307 100644 --- a/tests/test_etf_client.py +++ b/tests/test_etf_client.py @@ -39,6 +39,7 @@ def test_basic_info(): "Niche": "Broad-based", "Strategy": "Active", "Weighting Scheme": "Proprietary", + "Analyst Report": "https://etfdb.com/advisor_reports/JEPY/", } From 65b82cf103e05e5d0bb9d3f88cdee212dac90187 Mon Sep 17 00:00:00 2001 From: jp Date: Sat, 30 Mar 2024 12:22:57 +0100 Subject: [PATCH 2/2] feat: add analyst report to tabular --- etfpy/analytics/tabular_etf.py | 1 + 1 file changed, 1 insertion(+) diff --git a/etfpy/analytics/tabular_etf.py b/etfpy/analytics/tabular_etf.py index 632e05d..99c3446 100644 --- a/etfpy/analytics/tabular_etf.py +++ b/etfpy/analytics/tabular_etf.py @@ -116,6 +116,7 @@ def info(self): "Niche", "Strategy", "Weighting Scheme", + "Analyst Report", ] data = { k[:-1] if k.endswith(":") else k: v