-
Notifications
You must be signed in to change notification settings - Fork 10
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider na_string()
default for na.strings
#473
Labels
Comments
Merged
jmbarbone
changed the title
consider
consider Dec 14, 2022
na_strings()
default for na.strings
na_string()
default for na.strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
waiver function for explicit
na.strings
setting@JanMarvin , I did some testing and was able to implement this without having to update any of the tests. I'm pretty sure my poor handling of these is what's wrong with #471 .
This would help with using explicit values (definitely my preference; and we only have to check this once) but also (with another small internal adjustment) allow users to set their default strings value in
options()
.If we would want to use
We could allow zero length vectors (
character())
to replace theNULL
behavior withinwrite_data2()
; which currently errors throughtxt_to_is(character())
. Explicitly settingna.strings = NULL
would have the same effect; as would not setting it.The text was updated successfully, but these errors were encountered: