Check .csh and .pl for absolute paths (microsoft#1426)

* Check .csh and .pl for absolute paths * e2e test absolute path policy on script files
JavierMatosD · Jun 17, 2024 · c5e532a · c5e532a
1 parent 2e27bc7
commit c5e532a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/azure-pipelines/e2e-ports/vcpkg-policy-absolute-paths/portfile.cmake b/azure-pipelines/e2e-ports/vcpkg-policy-absolute-paths/portfile.cmake
@@ -22,6 +22,9 @@ endif()
 file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/include")
 file(WRITE "${CURRENT_PACKAGES_DIR}/include/vcpkg-policy-absolute-paths.h" "${PROBLEM_TEXT}")
 
+file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/tools/${PORT}/bin")
+file(WRITE "${CURRENT_PACKAGES_DIR}/tools/${PORT}/bin/port-config.sh" "${PROBLEM_TEXT}")
+
 if("policy" IN_LIST FEATURES)
     set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)
 endif()
diff --git a/azure-pipelines/end-to-end-tests-dir/post-build-checks.ps1 b/azure-pipelines/end-to-end-tests-dir/post-build-checks.ps1
@@ -970,6 +970,7 @@ note: Absolute paths were found in the following files
 $($packagesRoot)$($NativeSlash)vcpkg-policy-absolute-paths_$($Triplet): note: the files are relative to `${CURRENT_PACKAGES_DIR} here
 note: include/vcpkg-policy-absolute-paths.h
 note: share/pkgconfig/vcpkg-policy-absolute-paths.pc
+note: tools/vcpkg-policy-absolute-paths/bin/port-config.sh
 "@
 
 foreach ($bad_dir in @('build-dir', 'downloads', 'installed-root', 'package-dir')) {

diff --git a/src/vcpkg/postbuildlint.cpp b/src/vcpkg/postbuildlint.cpp
@@ -1515,7 +1515,7 @@ namespace vcpkg
         }
 
         if (extension == ".py" || extension == ".sh" || extension == ".cmake" || extension == ".pc" ||
-            extension == ".conf")
+            extension == ".conf" || extension == ".csh" || extension == ".pl")
         {
             const auto contents = fs.read_contents(file, IgnoreErrors{});
             return Strings::contains_any_ignoring_hash_comments(contents, searcher_paths);