-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Comments #9
Comments
Hey, I want to work on the issue, can I go ahead? |
@dragon540 sure go ahead |
Hey! |
@dragon540 you will need to install a lot of stuff for opengl development on Linux. Check out https://medium.com/geekculture/a-beginners-guide-to-setup-opengl-in-linux-debian-2bfe02ccd1e |
Do assign me this as I can contribute to this issue. |
@Jaysmito101 Assign this to me sir i can complete this issue |
@Bharadwajshivam28 @Shine-Gupta if you are interested in working create a relevant pull request . I will assign after that. |
ok sir @Jaysmito101 |
DO u assign me this project as i want to contribute in this issue |
ok sir |
@Jaysmito101 sir please elaborate this issue as i am not able to get the issue |
@Bharadwajshivam28 as the title says the job is to add comments to the functions in cgl.h to document them. These comments should be proper and descriptive explaining the function, its quirks, parameters, return types, etc. |
ok sir @Jaysmito101 |
hey @Jaysmito101, apologies for the delay since last interaction as I was occupied with college and my machine was broke due to some errors. I have installed OpenGL and can run opnegl examples now. But trying to compile cgl examples still throws error like
|
@Jaysmito101 Sir i am not able to identify the functions can you just give some hint that which are the functions or can you comment the line color of functions that which color of lines are functions |
@dragon540 cgl's implementation is inside CGL.h itself. The error you get is due to missing openal which is for audio. You have to set it up too. OpenGl is just for low level graphics where as CGL is for a lot lot more. |
@Bharadwajshivam28 take a look in CGL.h everything is in there. |
Ok sir will do it |
@Jaysmito101 I have installed openal related libraries. But then it showed "ft2hbuild.h" as missing, I could get around that by replacing |
@Jaysmito101 sir as much my knowledge i did commenting in functions can you review it so that i can go ahead |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as off-topic.
This comment was marked as off-topic.
These are samples sir @Jaysmito101 due to some issue i am not able to change changes please review it here sir |
@Bharadwajshivam28 as far as I can see it's ok but do not use single line comments like this but follow the format for doxygen ( check here https://www.cs.cmu.edu/~410/doc/doxygen.html) Edit: Try not to add too much in one go. First comment just say about 100 lines and make the pull request. Then after getting that merged continue with another pr. As if you make huge changes in a single pr it will probably not be reviewed in time. |
ok sir @Jaysmito101 |
so i am creating first pr beacuse i have done more so |
Hello, I can try to work on this problem. So ,can you please assign me this project @Jaysmito101 |
i want to contribute |
i want to work on this under jwoc |
Add comments to the header documenting the code.
Note comments must be added using the format specified for doxygen (https://www.cs.cmu.edu/~410/doc/doxygen.html)
The text was updated successfully, but these errors were encountered: