There are gaps around windows even when gap size is set to 0

[noahadvs]

http://i.imgur.com/lpIKPOB.png

[Jazqa]

I've intentionally blocked zero gaps for two reasons:

1. Windows get automatically maximized if they are closer than two pixels to the top edge of the screen (think dragging a window to the top edge).

2. KWin does not recognize maximized windows like it does minimized and fullscreen windows. In order to stop maximized windows from being tiled, I've decided to detect them by comparing their size to the screen size.

Both problems are solved by using either gaps of two pixels or a margin of two pixels. I will try my best to fix the issue, as I'd personally like to use the script without gaps too.

[Jazqa]

Is cheating okay? Everything works properly if I force 1px margins whenever gaps are set to zero.

EDIT: Committed, gaps can be set to zero now. I should have never told you about the margin, you might have never noticed.

[noahadvs]

It looks better now, but I like no gaps/margins because then I can bring my mouse all the way to the right side to grab a scroll bar instead of having to be precise. It's not a big issue though. I only use the scroll bar when I want to scroll a long distance quickly.

I didn't have a problem with the way the script worked before it was changed. I'd just make sure to leave windows unmaximized and move windows to the 2nd desktop to effectively maximize them. I could also make a Kwin rule to force disable vertical and horizontal maximization on all windows if I wanted to. I think an option to make it work like before in the script settings would be a good compromise if there isn't another solution, but it's not a big deal.

[Jazqa]

Quickly moving the mouse to the edge of the screen is a really good reason to add an option for gapless & marginless layout. I'll figure the best approach and implement a gapless & marginless option as soon as I can. Once again, thanks for your help!

[Jazqa]

Sorry this took forever, It's available in "beta" branch now (a branch I've used during my vacation because I can't test anything on multi-screen environment). I'll merge it with master as soon as I can confirm it works on multiple screens. I'm still not pleased with the solution as windows get automatically maximized but the option for zero gaps is there. (EDIT: Merged)

Also, for your own sanity. Use a margin of one pixel on one of the edges. I still haven't been able to figure out a better way to detect maximized windows, so a marginless & gapless setup is possible, but if you use a margin of a single pixel on any of the edges, you avoid a few issues.

[noahadvs]

I like that you put the one pixel margin on the bottom by default. It's barely noticeable, probably because of the window shadow.

[Jazqa]

Plus you rarely need to drag the cursor to the bottom edge of the screen. It's still just a workaround until I find a better way to recognize maximized windows.

[RaitaroH]

I like that you put the one pixel margin on the bottom by default. It's barely noticeable, probably because of the window shadow. Barely? Kinda annoys me but I understand it's purpose. Also it drove me mad why firefox wasn't resizing. It was maximized.

[Jazqa]

@RaitaroH, it really annoys me too. Unfortunately, it's either that or tiling maximized windows like regular ones. As far as I know, there is no way to tell if a Windows is maximized or not. This one has driven me nuts.

[RaitaroH]

XD I understand. I actually started using this today. I do have a thing for getting used to things rather fast. In a couple of days most likely I won't be able to use my pc without it.