From 30ec8b395a6077d0d3c74d9b32aec79b72214d07 Mon Sep 17 00:00:00 2001 From: ketaki-deodhar <116035339+ketaki-deodhar@users.noreply.github.com> Date: Fri, 26 Apr 2024 09:23:36 -0700 Subject: [PATCH] 19259 - show draft continuation in (#650) * 19259 - draft continuation in-1 * 19259 - draft continuation in-2 * 19259 - misc fixes and unit tests * 19259 - install again * 19259 - update package version * 19259 - update based on review * 19259 - update to use enumUtilities * 19259 - create a getter to show NR * 19259 - update comments --- package-lock.json | 44 ++--- package.json | 8 +- src/App.vue | 11 +- src/components/Dashboard/TodoList.vue | 96 +++++++++- src/components/EntityInfo/EntityHeader.vue | 13 +- src/enums/entityStatus.ts | 2 + src/interfaces/api-filing-interface.ts | 3 + src/interfaces/api-task-interface.ts | 1 + src/services/enum-utilities.ts | 6 + src/stores/businessStore.ts | 20 +++ src/stores/rootStore.ts | 12 +- tests/unit/App.spec.ts | 196 +++++++++++++++++++++ tests/unit/EntityHeader.spec.ts | 106 +++++++++++ tests/unit/enum-utilities.spec.ts | 2 + 14 files changed, 474 insertions(+), 46 deletions(-) diff --git a/package-lock.json b/package-lock.json index e2a0ede49..f4b32c8de 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,25 +1,25 @@ { "name": "business-filings-ui", - "version": "7.2.2", + "version": "7.2.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-filings-ui", - "version": "7.2.2", + "version": "7.2.3", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/base-address": "2.0.9", "@bcrs-shared-components/breadcrumb": "2.1.11", "@bcrs-shared-components/confirm-dialog": "1.2.1", - "@bcrs-shared-components/corp-type-module": "1.0.14", + "@bcrs-shared-components/corp-type-module": "1.0.16", "@bcrs-shared-components/court-order-poa": "2.1.4", "@bcrs-shared-components/date-picker": "1.2.39", "@bcrs-shared-components/document-delivery": "1.2.1", - "@bcrs-shared-components/enums": "1.1.9", + "@bcrs-shared-components/enums": "1.1.10", "@bcrs-shared-components/expandable-help": "1.0.1", "@bcrs-shared-components/folio-number-input": "1.1.18", - "@bcrs-shared-components/interfaces": "1.1.12", + "@bcrs-shared-components/interfaces": "1.1.13", "@bcrs-shared-components/mixins": "1.1.30", "@bcrs-shared-components/staff-comments": "1.3.11", "@bcrs-shared-components/staff-payment": "2.1.11", @@ -246,9 +246,9 @@ } }, "node_modules/@bcrs-shared-components/corp-type-module": { - "version": "1.0.14", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/corp-type-module/-/corp-type-module-1.0.14.tgz", - "integrity": "sha512-SZhJw4hpqQT2BL3RuVB0Z1hmShhrv5byhH4gnaF1fVl9jsUGkjC/Ytic08UnEX4DIyR1/VWNyjTclNgxi9+0Bw==" + "version": "1.0.16", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/corp-type-module/-/corp-type-module-1.0.16.tgz", + "integrity": "sha512-3MumJZ/0Urfnp1AGJpnUifk5DMrLcjDD+8YiGXy1WXjvpVLwA0S4bNPuvFUf0w4My+0HyXWZ/XsZWiQydVGYHw==" }, "node_modules/@bcrs-shared-components/court-order-poa": { "version": "2.1.4", @@ -287,18 +287,13 @@ } }, "node_modules/@bcrs-shared-components/enums": { - "version": "1.1.9", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.1.9.tgz", - "integrity": "sha512-rYmRG0QH9hMWXRJNrxzNQhM3tT/b6mubfLBREx2ICzUtSIDc9UvQ0VqmyX/q84xQdzAOYqh0Nth9vXYm7Ypdxg==", + "version": "1.1.10", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.1.10.tgz", + "integrity": "sha512-eKGpm0Nx5g+plhKdYiaUnLgwFsmBgyw/5yGcFAJm4jrPJY4VsDiYLFOEI9b5bEZKX9arSdAzNV5zmQneN8zD4w==", "dependencies": { - "@bcrs-shared-components/corp-type-module": "^1.0.15" + "@bcrs-shared-components/corp-type-module": "^1.0.16" } }, - "node_modules/@bcrs-shared-components/enums/node_modules/@bcrs-shared-components/corp-type-module": { - "version": "1.0.15", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/corp-type-module/-/corp-type-module-1.0.15.tgz", - "integrity": "sha512-g/TcNSR7zJsG2lBjn/NnM+/+k7dJzhAiy5PiPj0ObN56bUV1PrUWVVlg5lz4/JZUEAZetWhwnyAzPVGsn7kr1w==" - }, "node_modules/@bcrs-shared-components/expandable-help": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/@bcrs-shared-components/expandable-help/-/expandable-help-1.0.1.tgz", @@ -315,20 +310,15 @@ } }, "node_modules/@bcrs-shared-components/interfaces": { - "version": "1.1.12", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.1.12.tgz", - "integrity": "sha512-LR93tcUPyRoOrkLul2PBpGhgUXbDse7ZDT3MKlnMNOx8P+5vNjeowB/a7SAZo098QuNYkyhaRafhgqtM6kO+Eg==", + "version": "1.1.13", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.1.13.tgz", + "integrity": "sha512-+ukMaxz8mChD3gF5km8fW+afsO+7l4tZKyNsBkgWUVIC4eSqDO9XVSVOEAJS3e+R5dM4jdORbiHZzL4kkUT4ZQ==", "dependencies": { - "@bcrs-shared-components/corp-type-module": "^1.0.15", - "@bcrs-shared-components/enums": "^1.1.9", + "@bcrs-shared-components/corp-type-module": "^1.0.16", + "@bcrs-shared-components/enums": "^1.1.10", "vue": "^2.7.14" } }, - "node_modules/@bcrs-shared-components/interfaces/node_modules/@bcrs-shared-components/corp-type-module": { - "version": "1.0.15", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/corp-type-module/-/corp-type-module-1.0.15.tgz", - "integrity": "sha512-g/TcNSR7zJsG2lBjn/NnM+/+k7dJzhAiy5PiPj0ObN56bUV1PrUWVVlg5lz4/JZUEAZetWhwnyAzPVGsn7kr1w==" - }, "node_modules/@bcrs-shared-components/mixins": { "version": "1.1.30", "resolved": "https://registry.npmjs.org/@bcrs-shared-components/mixins/-/mixins-1.1.30.tgz", diff --git a/package.json b/package.json index 3689c4a60..d79638a17 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-filings-ui", - "version": "7.2.2", + "version": "7.2.3", "private": true, "appName": "Filings UI", "sbcName": "SBC Common Components", @@ -17,14 +17,14 @@ "@bcrs-shared-components/base-address": "2.0.9", "@bcrs-shared-components/breadcrumb": "2.1.11", "@bcrs-shared-components/confirm-dialog": "1.2.1", - "@bcrs-shared-components/corp-type-module": "1.0.14", + "@bcrs-shared-components/corp-type-module": "1.0.16", "@bcrs-shared-components/court-order-poa": "2.1.4", "@bcrs-shared-components/date-picker": "1.2.39", "@bcrs-shared-components/document-delivery": "1.2.1", - "@bcrs-shared-components/enums": "1.1.9", + "@bcrs-shared-components/enums": "1.1.10", "@bcrs-shared-components/expandable-help": "1.0.1", "@bcrs-shared-components/folio-number-input": "1.1.18", - "@bcrs-shared-components/interfaces": "1.1.12", + "@bcrs-shared-components/interfaces": "1.1.13", "@bcrs-shared-components/mixins": "1.1.30", "@bcrs-shared-components/staff-comments": "1.3.11", "@bcrs-shared-components/staff-payment": "2.1.11", diff --git a/src/App.vue b/src/App.vue index 2e08cb1bd..893cc70f5 100644 --- a/src/App.vue +++ b/src/App.vue @@ -214,13 +214,17 @@ export default class App extends Mixins( /** Currently supported entity types in Filings UI. */ supportedEntityTypes = [ - CorpTypeCd.BENEFIT_COMPANY, CorpTypeCd.BC_CCC, CorpTypeCd.BC_COMPANY, CorpTypeCd.BC_ULC_COMPANY, + CorpTypeCd.BEN_CONTINUE_IN, + CorpTypeCd.BENEFIT_COMPANY, + CorpTypeCd.CCC_CONTINUE_IN, + CorpTypeCd.CONTINUE_IN, CorpTypeCd.COOP, CorpTypeCd.PARTNERSHIP, - CorpTypeCd.SOLE_PROP + CorpTypeCd.SOLE_PROP, + CorpTypeCd.ULC_CONTINUE_IN ] // store references @Getter(useBusinessStore) getEntityName!: string @@ -614,6 +618,7 @@ export default class App extends Mixins( } const isAmalgamation = (filingName === FilingTypes.AMALGAMATION_APPLICATION) + const isContinuationInApplication = (filingName === FilingTypes.CONTINUATION_IN) const isIncorporationApplication = (filingName === FilingTypes.INCORPORATION_APPLICATION) const isRegistration = (filingName === FilingTypes.REGISTRATION) @@ -623,6 +628,7 @@ export default class App extends Mixins( case FilingStatus.PENDING: // this is a boostrap task if (isAmalgamation) entityStatus = EntityStatus.DRAFT_AMALGAMATION + else if (isContinuationInApplication) entityStatus = EntityStatus.DRAFT_CONTINUATION_IN else if (isIncorporationApplication) entityStatus = EntityStatus.DRAFT_INCORP_APP else if (isRegistration) entityStatus = EntityStatus.DRAFT_REGISTRATION else throw new Error(`Invalid ${filingName} filing - filing name`) @@ -632,6 +638,7 @@ export default class App extends Mixins( case FilingStatus.PAID: // this is a bootstrap filing if (isAmalgamation) entityStatus = EntityStatus.FILED_AMALGAMATION + else if (isContinuationInApplication) entityStatus = EntityStatus.FILED_CONTINUATION_IN else if (isIncorporationApplication) entityStatus = EntityStatus.FILED_INCORP_APP else if (isRegistration) entityStatus = EntityStatus.FILED_REGISTRATION else throw new Error(`Invalid ${filingName} filing - filing name`) diff --git a/src/components/Dashboard/TodoList.vue b/src/components/Dashboard/TodoList.vue index 8ade44fdf..81118e9c5 100644 --- a/src/components/Dashboard/TodoList.vue +++ b/src/components/Dashboard/TodoList.vue @@ -189,6 +189,14 @@ {{ item.subtitle }} + +
+ {{ item.subtitle }} +
+
-