Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must always have four options #50

Open
lekeope opened this issue Sep 7, 2018 · 9 comments
Open

Must always have four options #50

lekeope opened this issue Sep 7, 2018 · 9 comments
Assignees

Comments

@lekeope
Copy link

lekeope commented Sep 7, 2018

is there a way to override the mandatory four options?

@JoaquimLey JoaquimLey self-assigned this Sep 11, 2018
@JoaquimLey
Copy link
Owner

Hi @edge-developer.

What limitations did you face with setting up the buttons?

There isn't a requirement for 4 buttons 🤔

@JoaquimLey
Copy link
Owner

Do you feel ok closing this issue @edge-developer?

@lekeope
Copy link
Author

lekeope commented Sep 15, 2018

No man. Thanks for creating this awesome library.

What i mean is that, the FAB always requires 4 options in order not to look distorted

@lekeope
Copy link
Author

lekeope commented Sep 15, 2018

I love your work as it is, but i am wondering if there's a way to avoid making it distorted when you don't have four options.

@JoaquimLey
Copy link
Owner

Hey @edge-developer,

Thanks for the kind words, means a lot! :)

Can you please tell me which version of the library you are using and which device? If possible post a screenshot showcasing the issue.

I had tested with both 2, 3, 4 and 6 buttons and the menu would size itself just fine, but you might've found a bug ;)

@JoaquimLey JoaquimLey added the bug label Sep 16, 2018
@lekeope
Copy link
Author

lekeope commented Sep 20, 2018

@lekeope
Copy link
Author

lekeope commented Sep 20, 2018

Code was ran on API 28.

Can you see what i am saying?

It seems there has to be an even number of menu options

@JoaquimLey
Copy link
Owner

Hello @edge-developer,

Thank you so much for the screenshots, this helps to understand the issue. I might somewhat of an idea what's wrong and what might need changing.

It's not something super quick to fix since I'll need to implement a different way to calculate how the view should "grow".

It should be indirectly fixed when I implement directional menus #5

@lekeope
Copy link
Author

lekeope commented Sep 24, 2018

No Problem. Even as it is, i'm grateful you took out the time to write the library, i'm using it in my upcoming project i'm rebranding Win Status Saver to (goo.gl/UBwbqy) to A+ Status Saver which will soon be available goo.gl/iVB1iN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants