Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Disassemble Module Structuring #162

Closed
2 tasks done
Jon-Becker opened this issue Nov 3, 2023 · 1 comment · Fixed by #163
Closed
2 tasks done

[Bug]: Disassemble Module Structuring #162

Jon-Becker opened this issue Nov 3, 2023 · 1 comment · Fixed by #163

Comments

@Jon-Becker
Copy link
Owner

Component

Disassemble Library

Version

0.6.3

Please check the following

  • This is not a duplicate issue
  • I have checked the wiki and tried troubleshooting the issue

Operating System

macOS (Apple Silicon)

Command used to produce the issue

No response

Describe the issue you are facing

All libraries are exposed under the format use heimdall_core::{{module}}::{{Module}}ArgsBuilder;, except for disassemble which lives in heimdall_common::ether::evm::ext::disassemble.

TODO: add builder pattern and relocate disassembly code.

@Jon-Becker
Copy link
Owner Author

If not taken by another contributor by sunday, i'll likely complete for the monday release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant