[Bug]: Unable To Use Heimdall From Asynchronous Contexts

[bonedaddy]

Component

Decompile Library

Version

master, revision 6e6f051e373f7c098ee55c3eab70acc24cb77fa8

Please check the following

• This is not a duplicate issue
• I have checked the wiki and tried troubleshooting the issue

Operating System

Linux

Command used to produce the issue

Using decode_calldata(tx.input.clone().encode_hex())

Describe the issue you are facing

Usage within an asynchronous context results in the following error

thread '<unnamed>' panicked at 'Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.', /home/solidity/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.25.0/src/runtime/blocking/shutdown.rs:51:21

[bonedaddy]

Looks like the issue is due to the usage of blocking reqwest.

[Jon-Becker]

I'll take a look today

[bonedaddy]

@Jon-Becker unfortunately it doesn't look like a necessarily "simple" solution depending on what the desired solution is.

For my personal use case, simply changing the get_json_from_url function to usage of the async reqwest client was enough, but it required changing a large portion of the codebase to work with the new async function.

Changes are here if you are interested in taking a look https://github.com/bonedaddy/heimdall-rs/tree/feat/async

[Jon-Becker]

This looks to be minimal effort for a necessary solution. I'll handle this as soon as I have time <3

Thank you so much!

[bonedaddy]

Actually I was able to find a work around by calling the decoding function like so:

tokio::task::spawn_blocking::<_, _>(move || {
                                        // decode
                                    }).await;