From 51ab8135cb16be764092b932784749f49ca5d3d0 Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 15:28:27 -0500 Subject: [PATCH 1/8] perf: use hashbrown `HashMap`/`HashSet`s --- Cargo.lock | 6 ++++++ crates/common/Cargo.toml | 1 + crates/decode/Cargo.toml | 1 + crates/decode/src/core/mod.rs | 3 ++- crates/decode/src/utils/abi.rs | 2 +- crates/decompile/Cargo.toml | 1 + crates/decompile/src/core/mod.rs | 6 ++---- crates/decompile/src/core/out/abi.rs | 3 ++- crates/decompile/src/core/out/source.rs | 6 ++---- crates/decompile/src/core/postprocess.rs | 3 ++- crates/decompile/src/interfaces/function.rs | 2 +- crates/decompile/src/utils/heuristics/arguments.rs | 2 +- crates/dump/Cargo.toml | 1 + crates/dump/src/core/mod.rs | 4 +++- crates/inspect/Cargo.toml | 1 + crates/inspect/src/interfaces/contracts.rs | 2 +- crates/inspect/src/interfaces/traces.rs | 6 ++---- crates/vm/Cargo.toml | 1 + crates/vm/src/core/stack.rs | 7 +++---- crates/vm/src/core/storage.rs | 2 +- crates/vm/src/core/vm.rs | 2 +- crates/vm/src/ext/exec/mod.rs | 3 ++- crates/vm/src/ext/exec/util.rs | 2 +- crates/vm/src/ext/range_map.rs | 6 ++++-- crates/vm/src/ext/selectors.rs | 2 +- examples/decode_offline/Cargo.toml | 1 + examples/decode_offline/src/main.rs | 2 +- 27 files changed, 46 insertions(+), 32 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 98ba4134..67f55adf 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1970,6 +1970,7 @@ dependencies = [ "eyre", "fancy-regex", "futures", + "hashbrown", "heimdall-cache", "indicatif", "lazy_static", @@ -2042,6 +2043,7 @@ dependencies = [ "clap", "derive_builder", "eyre", + "hashbrown", "heimdall-cache", "heimdall-common", "heimdall-config", @@ -2063,6 +2065,7 @@ dependencies = [ "eyre", "fancy-regex", "futures", + "hashbrown", "heimdall-cache", "heimdall-common", "heimdall-config", @@ -2099,6 +2102,7 @@ dependencies = [ "derive_builder", "eyre", "futures", + "hashbrown", "heimdall-cache", "heimdall-common", "heimdall-config", @@ -2118,6 +2122,7 @@ dependencies = [ "derive_builder", "eyre", "futures", + "hashbrown", "heimdall-cache", "heimdall-common", "heimdall-config", @@ -2158,6 +2163,7 @@ dependencies = [ "crossbeam-channel", "eyre", "fancy-regex", + "hashbrown", "heimdall-cache", "heimdall-common", "indicatif", diff --git a/crates/common/Cargo.toml b/crates/common/Cargo.toml index bc25b5ed..0ec618f5 100644 --- a/crates/common/Cargo.toml +++ b/crates/common/Cargo.toml @@ -38,3 +38,4 @@ alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-t bytes = "1.6.1" alloy-dyn-abi = "0.7.7" tokio-retry = "0.3.0" +hashbrown = "0.14.5" diff --git a/crates/decode/Cargo.toml b/crates/decode/Cargo.toml index eb180586..1c9d1fb7 100644 --- a/crates/decode/Cargo.toml +++ b/crates/decode/Cargo.toml @@ -24,3 +24,4 @@ alloy-dyn-abi = "0.7.7" alloy-json-abi = "0.7.6" alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-trace"] } serde_json = "1.0" +hashbrown = "0.14.5" diff --git a/crates/decode/src/core/mod.rs b/crates/decode/src/core/mod.rs index ac87a043..31200286 100644 --- a/crates/decode/src/core/mod.rs +++ b/crates/decode/src/core/mod.rs @@ -1,4 +1,5 @@ -use std::{collections::HashSet, time::Instant}; +use hashbrown::HashSet; +use std::time::Instant; use alloy::primitives::Selector; use alloy_dyn_abi::{DynSolCall, DynSolReturns, DynSolType}; diff --git a/crates/decode/src/utils/abi.rs b/crates/decode/src/utils/abi.rs index caaf0514..76e064b0 100644 --- a/crates/decode/src/utils/abi.rs +++ b/crates/decode/src/utils/abi.rs @@ -1,4 +1,4 @@ -use std::collections::HashSet; +use hashbrown::HashSet; use alloy::primitives::{Selector, U256}; use alloy_dyn_abi::{DynSolCall, DynSolReturns, DynSolType, DynSolValue}; diff --git a/crates/decompile/Cargo.toml b/crates/decompile/Cargo.toml index 7c9c2811..ad9832c3 100644 --- a/crates/decompile/Cargo.toml +++ b/crates/decompile/Cargo.toml @@ -28,6 +28,7 @@ serde = { version = "1.0", features = ["derive"] } serde_json = "1.0" alloy-dyn-abi = "0.7.7" alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-trace"] } +hashbrown = "0.14.5" heimdall-disassembler.workspace = true heimdall-vm.workspace = true diff --git a/crates/decompile/src/core/mod.rs b/crates/decompile/src/core/mod.rs index 9bd98ad5..d606a2f1 100644 --- a/crates/decompile/src/core/mod.rs +++ b/crates/decompile/src/core/mod.rs @@ -7,6 +7,7 @@ use alloy::primitives::Address; use alloy_dyn_abi::{DynSolType, DynSolValue}; use alloy_json_abi::JsonAbi; use eyre::eyre; +use hashbrown::HashMap; use heimdall_common::{ ether::{ compiler::detect_compiler, @@ -20,10 +21,7 @@ use heimdall_vm::{ core::vm::VM, ext::selectors::{find_function_selectors, resolve_selectors}, }; -use std::{ - collections::HashMap, - time::{Duration, Instant}, -}; +use std::time::{Duration, Instant}; use crate::{ core::{ diff --git a/crates/decompile/src/core/out/abi.rs b/crates/decompile/src/core/out/abi.rs index 45615526..d49d5440 100644 --- a/crates/decompile/src/core/out/abi.rs +++ b/crates/decompile/src/core/out/abi.rs @@ -1,4 +1,5 @@ -use std::{collections::HashMap, time::Instant}; +use hashbrown::HashMap; +use std::time::Instant; use alloy_json_abi::{Error, Event, EventParam, Function, JsonAbi, Param, StateMutability}; diff --git a/crates/decompile/src/core/out/source.rs b/crates/decompile/src/core/out/source.rs index 1ed1481c..cc915795 100644 --- a/crates/decompile/src/core/out/source.rs +++ b/crates/decompile/src/core/out/source.rs @@ -1,7 +1,5 @@ -use std::{ - collections::{HashMap, HashSet}, - time::Instant, -}; +use hashbrown::{HashMap, HashSet}; +use std::time::Instant; use alloy_json_abi::StateMutability; diff --git a/crates/decompile/src/core/postprocess.rs b/crates/decompile/src/core/postprocess.rs index 0f97eb54..6219dd26 100644 --- a/crates/decompile/src/core/postprocess.rs +++ b/crates/decompile/src/core/postprocess.rs @@ -1,4 +1,5 @@ -use std::{collections::HashMap, time::Instant}; +use hashbrown::HashMap; +use std::time::Instant; use eyre::eyre; use heimdall_common::utils::strings::find_balanced_encapsulator; diff --git a/crates/decompile/src/interfaces/function.rs b/crates/decompile/src/interfaces/function.rs index e037f247..5a1a3ff0 100644 --- a/crates/decompile/src/interfaces/function.rs +++ b/crates/decompile/src/interfaces/function.rs @@ -1,4 +1,4 @@ -use std::collections::{HashMap, HashSet}; +use hashbrown::{HashMap, HashSet}; use alloy::primitives::U256; use heimdall_common::ether::signatures::ResolvedFunction; diff --git a/crates/decompile/src/utils/heuristics/arguments.rs b/crates/decompile/src/utils/heuristics/arguments.rs index 2d74cc20..5f5b6c93 100644 --- a/crates/decompile/src/utils/heuristics/arguments.rs +++ b/crates/decompile/src/utils/heuristics/arguments.rs @@ -1,4 +1,4 @@ -use std::collections::HashSet; +use hashbrown::HashSet; use alloy::primitives::U256; use eyre::eyre; diff --git a/crates/dump/Cargo.toml b/crates/dump/Cargo.toml index 9c14ee32..67686bd6 100644 --- a/crates/dump/Cargo.toml +++ b/crates/dump/Cargo.toml @@ -22,3 +22,4 @@ eyre = "0.6.12" tokio = { version = "1", features = ["full"] } futures = "0.3.30" alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-trace"] } +hashbrown = "0.14.5" diff --git a/crates/dump/src/core/mod.rs b/crates/dump/src/core/mod.rs index 74423e13..1e7a2e85 100644 --- a/crates/dump/src/core/mod.rs +++ b/crates/dump/src/core/mod.rs @@ -4,11 +4,13 @@ use alloy::{ }; use eyre::eyre; use futures::future::try_join_all; +use hashbrown::HashMap; use heimdall_common::{ ether::rpc::{get_block_state_diff, latest_block_number}, utils::time::{calculate_eta, format_eta}, }; -use std::{collections::HashMap, sync::Arc, time::Instant}; + +use std::{sync::Arc, time::Instant}; use tokio::sync::{Mutex, Semaphore}; use tracing::{debug, info}; diff --git a/crates/inspect/Cargo.toml b/crates/inspect/Cargo.toml index 149f9f50..8826fdc2 100644 --- a/crates/inspect/Cargo.toml +++ b/crates/inspect/Cargo.toml @@ -27,3 +27,4 @@ async-recursion = "1.0.5" tokio = { version = "1", features = ["full"] } alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-trace"] } serde_json = "1.0" +hashbrown = "0.14.5" diff --git a/crates/inspect/src/interfaces/contracts.rs b/crates/inspect/src/interfaces/contracts.rs index e04e1314..4095c97a 100644 --- a/crates/inspect/src/interfaces/contracts.rs +++ b/crates/inspect/src/interfaces/contracts.rs @@ -1,4 +1,4 @@ -use std::collections::{HashMap, HashSet}; +use hashbrown::{HashMap, HashSet}; use alloy::primitives::Address; use futures::future::try_join_all; diff --git a/crates/inspect/src/interfaces/traces.rs b/crates/inspect/src/interfaces/traces.rs index 7fb81cda..ba73353e 100644 --- a/crates/inspect/src/interfaces/traces.rs +++ b/crates/inspect/src/interfaces/traces.rs @@ -1,7 +1,5 @@ -use std::{ - borrow::BorrowMut, - collections::{HashSet, VecDeque}, -}; +use hashbrown::HashSet; +use std::{borrow::BorrowMut, collections::VecDeque}; use alloy::{ dyn_abi::DynSolValue, diff --git a/crates/vm/Cargo.toml b/crates/vm/Cargo.toml index 15b2a358..bc857a22 100644 --- a/crates/vm/Cargo.toml +++ b/crates/vm/Cargo.toml @@ -34,6 +34,7 @@ tracing = "0.1.40" eyre = "0.6.12" heimdall-common.workspace = true alloy = { version = "0.1.3", features = ["full", "rpc-types-debug", "rpc-types-trace"] } +hashbrown = "0.14.5" [features] step-tracing = [] diff --git a/crates/vm/src/core/stack.rs b/crates/vm/src/core/stack.rs index 3e32ab68..594ac1b5 100644 --- a/crates/vm/src/core/stack.rs +++ b/crates/vm/src/core/stack.rs @@ -1,11 +1,12 @@ use std::{ collections::VecDeque, fmt::Display, - hash::{Hash, Hasher}, + hash::{BuildHasher, Hash}, }; use alloy::primitives::U256; use eyre::{OptionExt, Result}; +use hashbrown::hash_map::DefaultHashBuilder; use super::opcodes::WrappedOpcode; @@ -258,9 +259,7 @@ impl Stack { /// assert_eq!(stack.hash(), 0x00); /// ``` pub fn hash(&self) -> u64 { - let mut hasher = std::collections::hash_map::DefaultHasher::new(); - self.stack.hash(&mut hasher); - hasher.finish() + DefaultHashBuilder::default().hash_one(&self.stack) } } diff --git a/crates/vm/src/core/storage.rs b/crates/vm/src/core/storage.rs index f7b70db7..fccb950c 100644 --- a/crates/vm/src/core/storage.rs +++ b/crates/vm/src/core/storage.rs @@ -1,4 +1,4 @@ -use std::collections::{HashMap, HashSet}; +use hashbrown::{HashMap, HashSet}; use alloy::primitives::U256; diff --git a/crates/vm/src/core/vm.rs b/crates/vm/src/core/vm.rs index 34308de2..688460d1 100644 --- a/crates/vm/src/core/vm.rs +++ b/crates/vm/src/core/vm.rs @@ -1,5 +1,5 @@ +use hashbrown::HashSet; use std::{ - collections::HashSet, ops::{Div, Rem, Shl, Shr}, time::{SystemTime, UNIX_EPOCH}, }; diff --git a/crates/vm/src/ext/exec/mod.rs b/crates/vm/src/ext/exec/mod.rs index e2cbc685..e7e0b4ef 100644 --- a/crates/vm/src/ext/exec/mod.rs +++ b/crates/vm/src/ext/exec/mod.rs @@ -18,8 +18,9 @@ use crate::{ }, }; use eyre::{OptionExt, Result}; +use hashbrown::HashMap; use heimdall_common::utils::strings::decode_hex; -use std::{collections::HashMap, time::Instant}; +use std::time::Instant; use tracing::{trace, warn}; #[derive(Clone, Debug, Default)] diff --git a/crates/vm/src/ext/exec/util.rs b/crates/vm/src/ext/exec/util.rs index 73eebbc0..38e86a41 100644 --- a/crates/vm/src/ext/exec/util.rs +++ b/crates/vm/src/ext/exec/util.rs @@ -1,4 +1,4 @@ -use std::collections::HashMap; +use hashbrown::HashMap; use alloy::primitives::U256; use heimdall_common::constants::{MEMORY_REGEX, STORAGE_REGEX}; diff --git a/crates/vm/src/ext/range_map.rs b/crates/vm/src/ext/range_map.rs index a58baf7b..834dc737 100644 --- a/crates/vm/src/ext/range_map.rs +++ b/crates/vm/src/ext/range_map.rs @@ -1,4 +1,5 @@ -use std::{collections::HashMap, ops::Range}; +use hashbrown::HashMap; +use std::ops::Range; use crate::core::opcodes::WrappedOpcode; @@ -117,7 +118,8 @@ impl RangeMap { #[cfg(test)] mod tests { - use std::{collections::HashMap, ops::Range}; + use hashbrown::HashMap; + use std::ops::Range; use crate::{core::opcodes::WrappedOpcode, ext::range_map::RangeMap}; diff --git a/crates/vm/src/ext/selectors.rs b/crates/vm/src/ext/selectors.rs index 4e7ace1f..1b8cd239 100644 --- a/crates/vm/src/ext/selectors.rs +++ b/crates/vm/src/ext/selectors.rs @@ -1,5 +1,5 @@ +use hashbrown::{HashMap, HashSet}; use std::{ - collections::{HashMap, HashSet}, sync::{Arc, Mutex}, time::Instant, }; diff --git a/examples/decode_offline/Cargo.toml b/examples/decode_offline/Cargo.toml index a7adc6a7..1694fe70 100644 --- a/examples/decode_offline/Cargo.toml +++ b/examples/decode_offline/Cargo.toml @@ -11,3 +11,4 @@ heimdall-decoder = { git = "https://github.com/Jon-Becker/heimdall-rs.git", tag serde = "1.0.196" serde_yaml = "0.9.31" tokio = "1.35.1" +hashbrown = "0.14.5" diff --git a/examples/decode_offline/src/main.rs b/examples/decode_offline/src/main.rs index a1996543..bd2e1b53 100644 --- a/examples/decode_offline/src/main.rs +++ b/examples/decode_offline/src/main.rs @@ -1,7 +1,7 @@ use heimdall_decoder::{decode, DecodeArgsBuilder}; use std::fs::File; use std::io::{BufRead, BufReader}; -use std::collections::HashMap; +use hashbrown::HashMap; use serde_yaml; use serde::{Deserialize, Serialize}; From 400e1ca431645f9d490681c0847ccdcc3cd508f1 Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:02:13 -0500 Subject: [PATCH 2/8] feat(actions): add bench action --- .github/workflows/bench.yml | 12 ++++++++++++ output.txt | 0 2 files changed, 12 insertions(+) create mode 100644 .github/workflows/bench.yml create mode 100644 output.txt diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml new file mode 100644 index 00000000..7a5fe840 --- /dev/null +++ b/.github/workflows/bench.yml @@ -0,0 +1,12 @@ +on: [pull_request] +name: bench +jobs: + runBenchmark: + name: run benchmark + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: boa-dev/criterion-compare-action@v3 + with: + branchName: ${{ github.base_ref }} + token: ${{ secrets.GITHUB_TOKEN }} diff --git a/output.txt b/output.txt new file mode 100644 index 00000000..e69de29b From 62ce8f05f9f54f6e047349faabb368f21fcaa782 Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:06:32 -0500 Subject: [PATCH 3/8] chore: update action runner, concurrency --- .github/workflows/bench.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 7a5fe840..1a0e34eb 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -1,9 +1,12 @@ on: [pull_request] name: bench +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + cancel-in-progress: true jobs: runBenchmark: name: run benchmark - runs-on: ubuntu-latest + runs-on: buildjet-16vcpu-ubuntu-2204 steps: - uses: actions/checkout@v3 - uses: boa-dev/criterion-compare-action@v3 From eb9b679b5ad37ba461337203684a0f4f9750e0eb Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:13:14 -0500 Subject: [PATCH 4/8] fix(action): disable bench for bin --- crates/cli/Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/cli/Cargo.toml b/crates/cli/Cargo.toml index 0be74f55..e02e382d 100644 --- a/crates/cli/Cargo.toml +++ b/crates/cli/Cargo.toml @@ -32,3 +32,4 @@ async-trait = "0.1.51" [[bin]] name = "heimdall" path = "src/main.rs" +bench = false From 61bb88c9eff7b4627c48640a6990b551162abf37 Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:20:21 -0500 Subject: [PATCH 5/8] fix(action): run core bench --- .github/workflows/bench.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 1a0e34eb..976bdcce 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -11,5 +11,6 @@ jobs: - uses: actions/checkout@v3 - uses: boa-dev/criterion-compare-action@v3 with: + package: "heimdall-core" branchName: ${{ github.base_ref }} token: ${{ secrets.GITHUB_TOKEN }} From 740e51fa12394d61d4c99859837c135c773f39ba Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:27:44 -0500 Subject: [PATCH 6/8] fix(action): troubleshooting --- crates/cache/Cargo.toml | 1 + crates/cfg/Cargo.toml | 1 + crates/cli/Cargo.toml | 1 + crates/common/Cargo.toml | 1 + crates/config/Cargo.toml | 1 + crates/decode/Cargo.toml | 1 + crates/decompile/Cargo.toml | 1 + crates/disassemble/Cargo.toml | 1 + crates/dump/Cargo.toml | 1 + crates/inspect/Cargo.toml | 1 + crates/tracing/Cargo.toml | 1 + crates/vm/Cargo.toml | 1 + 12 files changed, 12 insertions(+) diff --git a/crates/cache/Cargo.toml b/crates/cache/Cargo.toml index 13e7e203..dae8fd14 100644 --- a/crates/cache/Cargo.toml +++ b/crates/cache/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] clap = { workspace = true, features = ["derive"] } diff --git a/crates/cfg/Cargo.toml b/crates/cfg/Cargo.toml index 09be66ce..9b84bc81 100644 --- a/crates/cfg/Cargo.toml +++ b/crates/cfg/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/cli/Cargo.toml b/crates/cli/Cargo.toml index e02e382d..92b60ccf 100644 --- a/crates/cli/Cargo.toml +++ b/crates/cli/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] clap = { workspace = true, features = ["derive"] } diff --git a/crates/common/Cargo.toml b/crates/common/Cargo.toml index 0ec618f5..858bd18d 100644 --- a/crates/common/Cargo.toml +++ b/crates/common/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] async-openai = "0.10.0" diff --git a/crates/config/Cargo.toml b/crates/config/Cargo.toml index 4915dbee..56ea063b 100644 --- a/crates/config/Cargo.toml +++ b/crates/config/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-common = { workspace = true } diff --git a/crates/decode/Cargo.toml b/crates/decode/Cargo.toml index 1c9d1fb7..ec8d2a9a 100644 --- a/crates/decode/Cargo.toml +++ b/crates/decode/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/decompile/Cargo.toml b/crates/decompile/Cargo.toml index ad9832c3..b4e5737d 100644 --- a/crates/decompile/Cargo.toml +++ b/crates/decompile/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/disassemble/Cargo.toml b/crates/disassemble/Cargo.toml index 20b93bd4..51cea35b 100644 --- a/crates/disassemble/Cargo.toml +++ b/crates/disassemble/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/dump/Cargo.toml b/crates/dump/Cargo.toml index 67686bd6..7f621c57 100644 --- a/crates/dump/Cargo.toml +++ b/crates/dump/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/inspect/Cargo.toml b/crates/inspect/Cargo.toml index 8826fdc2..eb41ad21 100644 --- a/crates/inspect/Cargo.toml +++ b/crates/inspect/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] heimdall-config = { workspace = true } diff --git a/crates/tracing/Cargo.toml b/crates/tracing/Cargo.toml index 923a78e2..294816d7 100644 --- a/crates/tracing/Cargo.toml +++ b/crates/tracing/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] clap = { workspace = true, features = ["derive"] } diff --git a/crates/vm/Cargo.toml b/crates/vm/Cargo.toml index bc857a22..75fa8544 100644 --- a/crates/vm/Cargo.toml +++ b/crates/vm/Cargo.toml @@ -9,6 +9,7 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true +bench = false [dependencies] async-openai = "0.10.0" From 72a86e8ed10a3bc56ecee5a3915367a15721ba12 Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:33:10 -0500 Subject: [PATCH 7/8] fix(action): troubleshooting --- crates/cache/Cargo.toml | 2 ++ crates/cfg/Cargo.toml | 2 ++ crates/common/Cargo.toml | 3 +++ crates/config/Cargo.toml | 3 +++ crates/decode/Cargo.toml | 3 +++ crates/decompile/Cargo.toml | 3 +++ crates/disassemble/Cargo.toml | 3 +++ crates/dump/Cargo.toml | 3 +++ crates/inspect/Cargo.toml | 3 +++ crates/tracing/Cargo.toml | 3 +++ crates/vm/Cargo.toml | 3 +++ 11 files changed, 31 insertions(+) diff --git a/crates/cache/Cargo.toml b/crates/cache/Cargo.toml index dae8fd14..386e1b53 100644 --- a/crates/cache/Cargo.toml +++ b/crates/cache/Cargo.toml @@ -9,6 +9,8 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true + +[lib] bench = false [dependencies] diff --git a/crates/cfg/Cargo.toml b/crates/cfg/Cargo.toml index 9b84bc81..df7097f9 100644 --- a/crates/cfg/Cargo.toml +++ b/crates/cfg/Cargo.toml @@ -9,6 +9,8 @@ homepage.workspace = true repository.workspace = true keywords.workspace = true exclude.workspace = true + +[lib] bench = false [dependencies] diff --git a/crates/common/Cargo.toml b/crates/common/Cargo.toml index 858bd18d..2e26315d 100644 --- a/crates/common/Cargo.toml +++ b/crates/common/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] async-openai = "0.10.0" clap = { workspace = true, features = ["derive"] } diff --git a/crates/config/Cargo.toml b/crates/config/Cargo.toml index 56ea063b..c14427f2 100644 --- a/crates/config/Cargo.toml +++ b/crates/config/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-common = { workspace = true } clap = { workspace = true, features = ["derive"] } diff --git a/crates/decode/Cargo.toml b/crates/decode/Cargo.toml index ec8d2a9a..30a649df 100644 --- a/crates/decode/Cargo.toml +++ b/crates/decode/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-config = { workspace = true } heimdall-common = { workspace = true } diff --git a/crates/decompile/Cargo.toml b/crates/decompile/Cargo.toml index b4e5737d..632e6486 100644 --- a/crates/decompile/Cargo.toml +++ b/crates/decompile/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-config = { workspace = true } heimdall-common = { workspace = true } diff --git a/crates/disassemble/Cargo.toml b/crates/disassemble/Cargo.toml index 51cea35b..6be65837 100644 --- a/crates/disassemble/Cargo.toml +++ b/crates/disassemble/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-config = { workspace = true } heimdall-common = { workspace = true } diff --git a/crates/dump/Cargo.toml b/crates/dump/Cargo.toml index 7f621c57..c27e3914 100644 --- a/crates/dump/Cargo.toml +++ b/crates/dump/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-config = { workspace = true } heimdall-common = { workspace = true } diff --git a/crates/inspect/Cargo.toml b/crates/inspect/Cargo.toml index eb41ad21..a283afae 100644 --- a/crates/inspect/Cargo.toml +++ b/crates/inspect/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] heimdall-config = { workspace = true } heimdall-common = { workspace = true } diff --git a/crates/tracing/Cargo.toml b/crates/tracing/Cargo.toml index 294816d7..e337f175 100644 --- a/crates/tracing/Cargo.toml +++ b/crates/tracing/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] clap = { workspace = true, features = ["derive"] } tracing = "0.1.40" diff --git a/crates/vm/Cargo.toml b/crates/vm/Cargo.toml index 75fa8544..46a78e04 100644 --- a/crates/vm/Cargo.toml +++ b/crates/vm/Cargo.toml @@ -11,6 +11,9 @@ keywords.workspace = true exclude.workspace = true bench = false +[lib] +bench = false + [dependencies] async-openai = "0.10.0" clap = { workspace = true, features = ["derive"] } From 0839d95c6f9ec3b84b20752e33a13e4a7ff21b5f Mon Sep 17 00:00:00 2001 From: Jon-Becker Date: Tue, 6 Aug 2024 16:37:42 -0500 Subject: [PATCH 8/8] fix(action): troubleshooting --- crates/core/Cargo.toml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/core/Cargo.toml b/crates/core/Cargo.toml index 3576d6d3..cc0aeb3a 100644 --- a/crates/core/Cargo.toml +++ b/crates/core/Cargo.toml @@ -10,6 +10,9 @@ repository.workspace = true keywords.workspace = true exclude.workspace = true +[lib] +bench = false + [dependencies] async-recursion = "1.0.5" thiserror = "1.0.50"