Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 Tracking Issue #30

Closed
7 tasks done
JonahPlusPlus opened this issue Oct 1, 2022 · 0 comments
Closed
7 tasks done

0.5.0 Tracking Issue #30

JonahPlusPlus opened this issue Oct 1, 2022 · 0 comments

Comments

@JonahPlusPlus
Copy link
Owner

JonahPlusPlus commented Oct 1, 2022

Things to do when Bevy 0.9 is released.

  • Update to be 0.9 compliant

QOL changes:

  • Remove AtmosphereSkyBoxMaterial (unnecessary newtype) or make it an alias (Bevy 0.9 now requires impl Resource, so the Handle can't be used directly)
  • Add default procedural feature (controls whether the AtmospherePlugin adds the AtmospherePipelinePlugin) (Fixes Custom skybox texture? #29)
  • Add removal detection to detection feature
  • Remove dithering (Bevy 0.9 now adds dithering by default) (dithering is still necessary, it seems banding still occurs)
  • Explore compile time vs run time discrepancy (see more below)
  • Rename compute shader "time" variables to "depth" (to make it more accurate to the source literature)
  • Add more images to README

Potential Features:

Compile time vs run time discrepancy

As more features get added in, I should put more consideration into how things are organized. Sky models, for instance, can be organized into an enum and the variants can be feature-gated. In that case, the enum should be marked non-exhaustive, so changing the variant features won't cause a compile error. Besides that, it allows for adding new sky models in the future.

On that note, I should probably see if current features can receive the same treatment (allow for changing behavior at compile time and run time) to make them more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant