Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "up" direction in settings #49

Open
aevyrie opened this issue Jun 6, 2023 · 4 comments
Open

Add "up" direction in settings #49

aevyrie opened this issue Jun 6, 2023 · 4 comments

Comments

@aevyrie
Copy link

aevyrie commented Jun 6, 2023

I'm using Z-up in an application, so using this plugin results in everything being rotated 90 degrees. Being able to set the up vector would be handy.

@JonahPlusPlus
Copy link
Owner

Assuming you are using the Nishita model, that can be done by setting the ray_origin to (0.0, 0.0, 1.0). Of course, that is a model-dependent method and issue #39 addresses the need to have a way to add manual rotation.

@mattdm
Copy link

mattdm commented Sep 22, 2023

@JonahPlusPlus I have a question about "ray_origin". I'm playing with making the directional light come from the right place for the time of day at a given latitude. For the sky to match, should ray_origin be set to the zenith?

@JonahPlusPlus
Copy link
Owner

JonahPlusPlus commented Sep 22, 2023

@mattdm I'm not really sure what your use case is, but if you are trying to rotate the sky independent of the camera, then yes, the ray_origin can do this, you just set it to the direction that is "up", the zenith as you say. Though, you might want to look into just rotating the sky mesh (IDK if that can be done, others have been maintaining the project in my absence) since that is not as computationally expensive (but if you are changing other parameters as well, it doesn't matter).

@mattdm
Copy link

mattdm commented Sep 24, 2023

Use case is simply simulating sunlight and sun-position at non-equitorial latitudes. Changing sun_position seems to align the sky nicely — but I'm not sure what this parameter does for the model, and want to make sure I'm not missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants