Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sun itself? #58

Open
mattdm opened this issue Sep 26, 2023 · 2 comments
Open

The sun itself? #58

mattdm opened this issue Sep 26, 2023 · 2 comments

Comments

@mattdm
Copy link

mattdm commented Sep 26, 2023

Aas far I can see, the models don't actually depict the disk of the sun itself — just, as the name suggests, its effect on the atmosphere.

What's the best way to do this? I can calculate the proper position in the sky (there are several rust crates that have the real-world algorithms already done) — should I put a literal sphere there, or... is there a better way?

@mattdm
Copy link
Author

mattdm commented Sep 27, 2023

I know this is more a discussion question rather than an issue. Is there a better place for this kind of thing?

@mattdm
Copy link
Author

mattdm commented Oct 9, 2023

One idea might be to extend the Nishita shader to draw the sun's disk (and a diffuse atmospheric "halo") at the proper position, color-shifted appropriately. I'm imagining something looking kind of like this, from a Minute Physics video...

image

https://www.youtube.com/watch?v=NafbGOQBlQs&t=87s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant