Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testers wanted for SharePy v2 #48

Open
JonathanHolvey opened this issue Jan 2, 2021 · 4 comments
Open

Testers wanted for SharePy v2 #48

JonathanHolvey opened this issue Jan 2, 2021 · 4 comments
Milestone

Comments

@JonathanHolvey
Copy link
Owner

A release of SharePy v2 has been in the works for quite a while, but has been held up due to a lack of testing. This release introduces support for federated authentication, with the SharePointADFS auth class, however, I don't have access to an ADFS-enabled site to test it throughly.

If you want to help out with testing, please install it using pip:

pip install --pre sharepy

If you find a bug, please create an issue with v2 in the title. Be sure to include as much detail as possible in your bug report, including:

  • The version of SharePy you installed
  • The authentication type your site is using (run sharepy.auth.detect('user@example.com') if you're not sure)
  • Any errors and tracebacks you see

Changelog

A major refactor of SharePy to provide a standard Requests auth interface.

  • Converted the existing SharePoint Online authentication to a Requests auth class
  • Added ADFS auth to compliment the default SharePoint Online authentication. Thanks to @joemeneses
  • Added automatic authentication method detection for sharepy.connect()
  • Added version checking for saved session objects. Major version number changes invalidate a session
  • Removed auth_tld argument from sharepy.connect() and replaced with an login_url property in auth classes
  • Removed connection status messages and added Python exceptions when errors are encountered
  • Fixed session files not being closed when reading and writing
  • Fixed missing dependencies in PyPI package
  • Added setup.py script to repository
@JonathanHolvey JonathanHolvey added this to the v2.0.0 milestone Jan 2, 2021
@karimabuseer
Copy link

Hey Jonathan. How's testing going? Happy to join in testing if still helpful.

@JonathanHolvey
Copy link
Owner Author

Hi @karimabuseer. I ended up releasing to production without having much input from users, and as a result there are some bugs that have been raised. Perhaps you could try to reproduce the issues described in #49 and #59?

@karimabuseer
Copy link

Sure thing. I'll ping off some requests with the the different headers this weekend to identify when each should be used

@JonathanHolvey
Copy link
Owner Author

@karimabuseer did you get anywhere with your testing in the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants