Couple issues with this library

[adelowo]

Nice work man but i have got a couple complaints.

• The re-defined array_key_exists function 1. That is at best confusing since PHP also provides that method (same name) and the implementations are different (yours check if multiple keys exist in an array WHILE PHP checks for just a single key/index ).. I feel it should be renamed.

Another issue with the function is this (), you are making use of function_exists but you didn't take into consideration that the helper functions are namespaced. It should be

if (!function_exists('PayantNG\Payant\array_key_exists') 
{
    //code block
}

• Another issue is the inconsistency in code style. In some places, braces are on the same line 3 4, while in others, they are placed on the next line 5.

Another here is indentation inconsistency 6 (to be honest, the entire file, but here is a subset ). Might want to look into 7 and 8

• Unit Tests ?

I don't mean to be an asshole

[JonathanItakpe]

Thank you for the suggestions, please make a pull Request.

The function is called array_keys_exist - php's inbuilt function is array_key_exists

but feel free to correct and make a PR.

[adelowo]

Sorry been busy with other stuffs and didn't check this out.

Not too sure if i have the time to fix that but i should be able to get some free time on monday. Let's see how that goes

[JonathanItakpe]

Alright cool.