-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple issues with this library #2
Comments
Thank you for the suggestions, please make a pull Request. The function is called array_keys_exist - php's inbuilt function is array_key_exists but feel free to correct and make a PR. |
Sorry been busy with other stuffs and didn't check this out. Not too sure if i have the time to fix that but i should be able to get some free time on monday. Let's see how that goes |
Alright cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nice work man but i have got a couple complaints.
array_key_exists
function 1. That is at best confusing sincePHP
also provides that method (same name) and the implementations are different (yours check if multiple keys exist in an array WHILEPHP
checks for just a single key/index ).. I feel it should be renamed.Another issue with the function is this (), you are making use of
function_exists
but you didn't take into consideration that the helper functions are namespaced. It should beAnother here is indentation inconsistency 6 (to be honest, the entire file, but here is a subset ). Might want to look into 7 and 8
The text was updated successfully, but these errors were encountered: