Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to detect single sentence spanning multiple lines #25

Open
andrewrynhard opened this issue Aug 17, 2019 · 4 comments
Open

Fails to detect single sentence spanning multiple lines #25

andrewrynhard opened this issue Aug 17, 2019 · 4 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@andrewrynhard
Copy link

andrewrynhard commented Aug 17, 2019

Fails to detect when a single sentence spans multiple lines:

$ cat test.md
# Test

This is a single sentence that spans
multiple lines.
$ markdownlint --rules ./node_modules/sentences-per-line/index.js test.md
$ echo $?
0
$
@andrewrynhard andrewrynhard changed the title Fails to detect Fails to detect single sentence spanning multiple lines Aug 17, 2019
@JoshuaKGoldberg
Copy link
Owner

Ha, good find. I think it's reasonable to add this as an opt-in optional rule flag, as it's common practice to split long sentences across lines. How about the following options:

  • true to only allow one sentence per line: no more, no less
  • A number to allow a sentence to split across lines if its length is > that number?

@andrewrynhard
Copy link
Author

Sounds reasonable to me!

@JoshuaKGoldberg JoshuaKGoldberg transferred this issue from JoshuaKGoldberg/sentences-per-line-old Nov 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Nov 12, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @andrewrynhard for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @andrewrynhard! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants