Multi-level min branching ignored?

[u1735067]

Bug description

Hi,
I'm unable to reproduce the CATALOG_MIN_BRANCHES=1 + CATALOG_MAX_BRANCHES=2 case described in #319, am I missing something?

And while writing this, I think I understand, unlike in your test (https://github.com/Joxit/docker-registry-ui/pull/319/files#diff-702e29248f45a8a8d33d76ef028e6b85147aafab11751e0e215917ccf45523f3R73), I don't have images at the docker.io/ level.

So if it's this, it's more of a feature request, could it be possible to force a first level?

Like this:

docker.io/
    docker.io/authelia/authelia
    docker.io/grafana/
        docker.io/grafana/grafana-oss
        docker.io/grafana/grafana-oss-dev

How to Reproduce

My docker-compose file

  registry-ui-joxit:
    image: docker.io/joxit/docker-registry-ui:2.5.6
    depends_on:
      - registry
    environment:
      TZ: *TZ
      SINGLE_REGISTRY: "true"
      PULL_URL: "https://..."
      NGINX_PROXY_PASS_URL: "..."
      NGINX_RESOLVER: "127.0.0.11"
      REGISTRY_TITLE: "My registry"
      DELETE_IMAGES: "true"
      SHOW_CONTENT_DIGEST: "true"
      SHOW_CATALOG_NB_TAGS: "true"
      #HISTORY_CUSTOM_LABELS: "label1,label2"
      CATALOG_DEFAULT_EXPANDED: "true"
      CATALOG_MIN_BRANCHES: "1"
      CATALOG_MAX_BRANCHES: "2"

My resulting HTML element

<docker-registry-ui
      registry-url=""
      name="My registry"
      pull-url="https://my.registry"
      show-content-digest="true"
      is-image-remove-activated="true"
      catalog-elements-limit=""
      single-registry="true"
      default-registries=""
      read-only-registries=""
      show-catalog-nb-tags="true"
      history-custom-labels=""
      use-control-cache-header=""
      taglist-order=""
      catalog-default-expanded="true"
      catalog-min-branches="1"
      catalog-max-branches="2"
      is-registry-secured=""
      theme=""
      theme-primary-text=""
      theme-neutral-text=""
      theme-background=""
      theme-hover-background=""
      theme-accent-text=""
      theme-header-text=""
      theme-header-background=""
      theme-footer-text=""
      theme-footer-neutra-text=""
      theme-footer-background=""
      tags-per-page=""
    >

Expected behavior

Screenshots

[Joxit]

Hello, thank you for using my project and submitting issues 😄

I didn't cover this use case, the repository will be expendable only when there is at least one leaf/final image. That means if you push docker.io/alpine or any root image from docker hub for example, it will give you the wanted behaviour.

I thought it was more readable like this since they are all final images except for grafana which contains two images 🤔

Should I change this behaviour ?

[mqhamdam]

@Joxit it was confusing to me too. I though i did something wrong. Maybe adding folder, image, tag icon make it easier to understand list tile type ?

[u1735067]

Hello, thank you for using my project and submitting issues 😄

Thank you for this project :)

There aren't a lot of (simple) options to display the content of a registry, the other I found is https://github.com/klausmeyer/docker-registry-browser (with a different approach).

I didn't cover this use case, the repository will be expendable only when there is at least one leaf/final image. That means if you push docker.io/alpine or any root image from docker hub for example, it will give you the wanted behaviour.

I thought it was more readable like this since they are all final images except for grafana which contains two images 🤔

Should I change this behaviour ?

My use case is mirroring registries (Docker hub, GCR, GHCR, Quay, Gitlab registry) + custom namespaces, so having a mandatory first level would be nice, maybe a CATALOG_FOLD_MERGE_LEVEL option (but with better naming?), that indicate a level from which path can be "merged"?

However I'm migrating to another platform and won't be using this registry anymore, so maybe other users should weight in to tell if they're interested by this feature, to not be wasted.

[Joxit]

Okay.
I could change the send icon to a folder one for example 🤔
And an option like catalog-force-branches is possible too, but it will force all of them