From 2dba2bf1c09be53a09d3f5813d7ebd9da8f5ebc1 Mon Sep 17 00:00:00 2001
From: Theophile Sandoz <theophile.sandoz@gmail.com>
Date: Wed, 10 Apr 2024 13:22:40 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=8F=20Display=20decimal=20parts=20in?=
 =?UTF-8?q?=20numeric=20statistics=20(#4828)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Display decimal parts in numeric statistics
---
 .../ui/src/app/pages/Proposals/ProposalPreview.stories.tsx  | 6 +++---
 .../src/common/components/statistics/NumericValueStat.tsx   | 6 ++++--
 packages/ui/src/mocks/data/proposals.ts                     | 6 +++---
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/ui/src/app/pages/Proposals/ProposalPreview.stories.tsx b/packages/ui/src/app/pages/Proposals/ProposalPreview.stories.tsx
index a22e15fcb2..83c3710b9d 100644
--- a/packages/ui/src/app/pages/Proposals/ProposalPreview.stories.tsx
+++ b/packages/ui/src/app/pages/Proposals/ProposalPreview.stories.tsx
@@ -136,15 +136,15 @@ export default {
             },
             referendum: { stage: {} },
             projectToken: {
-              ammBuyTxFees: 10_000,
-              ammSellTxFees: 20_000,
+              ammBuyTxFees: 1_000,
+              ammSellTxFees: 2_000,
               bloatBond: joy(0.1),
               maxYearlyPatronageRate: 500_000,
               minAmmSlopeParameter: joy(10),
               minRevenueSplitDuration: 100,
               minRevenueSplitTimeToStart: 200,
               minSaleDuration: 300,
-              salePlatformFee: 30_000,
+              salePlatformFee: 3_000,
             },
           },
 
diff --git a/packages/ui/src/common/components/statistics/NumericValueStat.tsx b/packages/ui/src/common/components/statistics/NumericValueStat.tsx
index 584a059bc7..aee1499469 100644
--- a/packages/ui/src/common/components/statistics/NumericValueStat.tsx
+++ b/packages/ui/src/common/components/statistics/NumericValueStat.tsx
@@ -12,7 +12,9 @@ export interface NumericValueStatProps extends StatisticItemProps {
 }
 
 export const NumericValueStat: FC<NumericValueStatProps> = (props) => {
-  if (!isDefined(props.value)) {
+  const value = typeof props.value === 'number' ? props.value.toString() : props.value
+
+  if (!isDefined(value)) {
     return (
       <StatisticItem {...props}>
         <span>-</span>
@@ -22,7 +24,7 @@ export const NumericValueStat: FC<NumericValueStatProps> = (props) => {
 
   return (
     <StatisticItem {...props}>
-      <NumericValue>{formatTokenValue(props.value)}</NumericValue>
+      <NumericValue>{formatTokenValue(value)}</NumericValue>
       {props.children}
     </StatisticItem>
   )
diff --git a/packages/ui/src/mocks/data/proposals.ts b/packages/ui/src/mocks/data/proposals.ts
index 469e6d9f57..43dbce3ffc 100644
--- a/packages/ui/src/mocks/data/proposals.ts
+++ b/packages/ui/src/mocks/data/proposals.ts
@@ -96,14 +96,14 @@ const proposalDetails: Record<ProposalDetailsType, RecursivePartial<ProposalWith
   SetEraPayoutDampingFactorProposalDetails: { dampingFactor: 60 },
   DecreaseCouncilBudgetProposalDetails: { amount: joy(100) },
   UpdateTokenPalletTokenConstraintsProposalDetails: {
-    maxYearlyRate: 0.4 * 10 ** 6,
+    maxYearlyRate: 400_000,
     minAmmSlope: undefined,
     minSaleDuration: 200,
     minRevenueSplitDuration: undefined,
     minRevenueSplitTimeToStart: 5,
-    salePlatformFee: 10_000,
+    salePlatformFee: 0,
     ammBuyTxFees: undefined,
-    ammSellTxFees: 0.003 * 10 ** 6,
+    ammSellTxFees: 300,
     bloatBond: joy(0.01),
   },
 }