Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mirr function in financial_math.jl #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KuldeepBorkar
Copy link
Contributor

Modified IRR which was not included in financial_math.jl is implemented now via present_value

Fixes #61

@alecloudenback
Copy link
Member

Please add some new tests to complement the new function (e.g you can probably Google and find a public example, or use Excel and refer to the value it calculates)

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #91 (417e6fa) into master (bf6e13b) will decrease coverage by 3.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   97.97%   94.63%   -3.35%     
==========================================
  Files           4        4              
  Lines         198      205       +7     
==========================================
  Hits          194      194              
- Misses          4       11       +7     
Flag Coverage Δ
unittests 94.63% <0.00%> (-3.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/financial_math.jl 92.99% <0.00%> (-4.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alecloudenback
Copy link
Member

Hello, in addition to the tests one other thing that would be good to do before implementing:

  • use accumulation and discount where applicable, which will allow users to flexibly input Yields.jl objects and not just Float64 annual effective rates.

@KuldeepBorkar
Copy link
Contributor Author

Hello, in addition to the tests one other thing that would be good to do before implementing:

  • use accumulation and discount where applicable, which will allow users to flexibly input Yields.jl objects and not just Float64 annual effective rates.

I will try to work on this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more profit measures
2 participants