-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size checking in mul!
is too strict
#132
Comments
Just saw that #127 resolves this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
isequal_blocksizes
check hereBlockDiagonals.jl/src/linalg.jl
Lines 141 to 142 in 9b07a07
is much too strict. See for example this code:
To fix this, we should change the
isequal_blocksizes
check with an actual proper check that the sizes work together.Alternatively a more lazy version would just check that
length(C.blocks) == length(A.blocks) == length(B.blocks)
, and then just callmul!
which performs a size check anyways.The text was updated successfully, but these errors were encountered: