Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntSet tests in release-0.18 branch are broken on julia 1.9+ #864

Closed
oxinabox opened this issue Aug 3, 2023 · 4 comments
Closed

IntSet tests in release-0.18 branch are broken on julia 1.9+ #864

oxinabox opened this issue Aug 3, 2023 · 4 comments

Comments

@oxinabox
Copy link
Member

oxinabox commented Aug 3, 2023

Works fine in 1.8 but but after 1.9 it fails.
Master branch has it working fine.
I haven't looked into why

@oxinabox oxinabox changed the title IntSet tests in release-18-* branch are broken on julia 1.9+ IntSet tests in release-18 branch are broken on julia 1.9+ Aug 3, 2023
@oxinabox oxinabox changed the title IntSet tests in release-18 branch are broken on julia 1.9+ IntSet tests in release-0.18 branch are broken on julia 1.9+ Aug 3, 2023
@StephenVavasis
Copy link
Contributor

I have traced the problem to a bug in Base.map!. I have opened an issue:
JuliaLang/julia#50780

@StephenVavasis
Copy link
Contributor

Sorry, I got this wrong: map!(|,a,b) does not replace a with the bitwise OR of a and b as I had assumed, as explained by the respondent to my issue JuliaLang/julia#50780 . However, I now don't understand how union of IntSets ever worked. Line 94 of int_set.jl seems to rely on the fact that map!(|,a,b) replaces a with a bitwise OR. I will try to return to this later.

@StephenVavasis
Copy link
Contributor

StephenVavasis commented Aug 3, 2023

OK, I figured it out: the bug is in Base.map!(|,a,a,b) not Base.map!(|,a,b) as I said earlier. I reopened my issue.

@laborg
Copy link
Collaborator

laborg commented Oct 3, 2023

The underlying issue has been fixed. This issue can be closed.

@laborg laborg closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants