Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving performance with TableView #45

Open
pdeffebach opened this issue May 7, 2020 · 2 comments
Open

Improving performance with TableView #45

pdeffebach opened this issue May 7, 2020 · 2 comments

Comments

@pdeffebach
Copy link
Contributor

pdeffebach commented May 7, 2020

@pfitzseb let me say thank you for your work on TableView.

Partly in response to #32 I have been working on my own package called FloatingTableView. I am wondering how to make the package better.

It essentially just defines a Blink.Window and fills it with the output of showtable. Currently, it's a bit slower "time to first table view" than I am hoping for.

I am wondering what changes you have in mind on either my end or yours to improve performance.

  1. Opening a blink window is sluggish. Do you think that I would see a significant performance improvement if I opened the table in a browser using Mux? I have been reading documentation on this and cannot figure it out. If possible, could you add instructions on this to the readme?
  2. Viewing 1000 or more columns makes scrolling a bit slow. Do you think it would be possible to change the default number of columns loaded in memory to be smaller?
  3. I don't have any interest in edit functionalities, and don't know how to implement them using my Blink window. Would there be performance improvements if the kind of "watching" that ag-grid does were turned off? Perhaps the fact that cells can be edited in the future is slowing things down.

I am very interested in what is possible with a command-line table viewing tool. Please let me know if you have any thoughts on the above points.

Thank you

@pfitzseb
Copy link
Member

Opening a blink window is sluggish. Do you think that I would see a significant performance improvement if I opened the table in a browser using Mux? I have been reading documentation on this and cannot figure it out. If possible, could you add instructions on this to the readme?

That's very likely faster, yes. In theory

using WebIO, Mux, TableView
WebIO.webio_serve(showtable(rand(10,10))

should do the trick, but that fails with JuliaGizmos/WebIO.jl#415 atm.

Viewing 1000 or more columns makes scrolling a bit slow. Do you think it would be possible to change the default number of columns loaded in memory to be smaller?

AFAICT that's not possible. We can (should) however switch to async viewing based on the number of displayed elements, not displayed rows (as is happening currently).

I don't have any interest in edit functionalities, and don't know how to implement them using my Blink window. Would there be performance improvements if the kind of "watching" that ag-grid does were turned off? Perhaps the fact that cells can be edited in the future is slowing things down.

Possible but unlikely.

@pdeffebach
Copy link
Contributor Author

Thanks for the reply on this.

I've been able to get that far with Mux, but I'm stuck on the last step. How do I get a Task (runnable) to display in the browser? Any help is appreciated. I can't find docs on this anywwhere.

With regards to editing, is it possible to edit on any of the displays for TableView? I haven't been able to get editing to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants