New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix premature lowering of `K"core_@cmd"` etc #438

Closed

c42f opened this issue Jun 13, 2024 · 0 comments · Fixed by #480

Labels

Member

c42f commented Jun 13, 2024 •

edited

Loading

There are four macrocalls to special Kinds which are arguably premature lowering.

K"core_@cmd"
K"core_@int128_str"
K"core_@uint128_str"
K"core_@big_str"

In the same way that we removed K"core_@doc previously (see #217), these should have their own kinds instead:

K"cmdstring" # ??
K"Int128"
K"UInt128"
K"BigInt"

For K"core_@cmd" there might be some thought required: it could be either

A single K"CmdString", with the delimiters as separate trivia tokens in the parent?
A K"cmdstring" container - in analogy to K"string" - with a K"String" or K"CmdString" chunk inside?

The text was updated successfully, but these errors were encountered:

c42f added AST breaking labels

c42f mentioned this issue

Release 1.0.0 #472

Open

c42f mentioned this issue

Fix premature lowering of cmd strings #480

Merged

c42f closed this as completed in #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment