Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to request the diff with their current state #78

Open
pankgeorg opened this issue Jul 1, 2022 · 1 comment
Open

Allow clients to request the diff with their current state #78

pankgeorg opened this issue Jul 1, 2022 · 1 comment

Comments

@pankgeorg
Copy link
Member

Diffing with the initial notebook state can be significantly bigger than diffing with the "previous" state, especially if there is a file input somewhere. In this proposal we would send both the current C and the previous P state values and caclulate the diff between P and C, then send this diff back to the client.

Given that state P must be already calculated by the same server, it could be memoized already somewhere in the server, to avoid duplicate calculations (given no rand(), of course)

Note that PlutoSliderServer currenty always diffs to the initial state of each notebook.

@fonsp
Copy link
Member

fonsp commented Sep 1, 2022

Tricky! But I am open to contributions here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants