Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up release branch in commit comment #200

Open
christopher-dG opened this issue Apr 16, 2021 · 0 comments
Open

Look up release branch in commit comment #200

christopher-dG opened this issue Apr 16, 2021 · 0 comments
Labels
rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before.

Comments

@christopher-dG
Copy link
Member

@property
def _release_branch(self) -> str:
"""Get the name of the release branch."""
return self.__release_branch or self._repo.default_branch

The code above means "Static release branch set in TagBot config if it's set, otherwise the repo's default branch". It's ignoring release branch info from a Registrator invocation like @JuliaRegistrator register branch=foo.

The actual effect of this is we miss out on the nice "N commits since this release" for those latter releases.

The priority for release branch selection should be:

  1. Branch specified by Registrator invocation
  2. Release branch specified in TagBot config
  3. Default branch

Right now we're just missing (1). We can look up the commit comment by reading the registry PR body, but we're out of luck for the web UI.

I won't get to this soon but I'll keep it in mind for the rewrite ™️

@christopher-dG christopher-dG added the rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before. label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before.
Projects
None yet
Development

No branches or pull requests

1 participant