Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle yanked releases #72

Open
christopher-dG opened this issue Feb 24, 2020 · 1 comment
Open

Handle yanked releases #72

christopher-dG opened this issue Feb 24, 2020 · 1 comment
Labels
rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before.

Comments

@christopher-dG
Copy link
Member

When a release is yanked (marked as uninstallable) from a registry, its entry in the Versions.toml has yanked = true inserted. That make new yanks easily detectable by TagBot. But what's the right thing to do with a yanked release?

Options would appear to be:

  1. Delete it and the Git tag (not a fan, tags are supposed to be immutable)
  2. Delete it but leave the Git tag intact (seems fine but might leave people wondering "hey why does this tag have no release")
  3. Delete it and replace the Git tag with an identical one, but annotated and with a message like "this release has been yanked" (seems ideal and most similar to what is happening in the registry, but technically violates the "tags are immutable" thing)
  4. Only update the changelog (seems cool if we want to be safe and not touch Git tags)

Personally I think option 3 seems best. When replacing a tag with git push origin --tags --force, I don't think there is any chance of the tag being deleted and not replaced.

@fredrikekre
Copy link
Member

Does anyone look at GH releases anyway? I think option 4 looks fine.

@christopher-dG christopher-dG added the rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before. label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewrite Will be done in the Julia rewrite of TagBot (see #55), but not before.
Projects
None yet
Development

No branches or pull requests

2 participants