-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match the Manifolds.jl notation in doc #839
Comments
Hi @kellertuer, great, thanks for the notes and pointers on ManifoldsBase.jl v0.13.0. Will do the fixes. I caught the wave to hold back with the updates until Manifolds.jl is tagged but have not yet been able to dig through all the code to learn what the changes were. I saw some of those PRs were pretty large. So the few comments here help us a lot, thanks! Oh yeah, I strongly second the notation nerd comment, I'm biased to following the notation you have in JuliaManifolds. For us working the navigation problem, the number one issue is ALWAYS figuring out what all conventions are, as used by different groups. So notation is super super important and my sense is there should be zero friction when looking at the factor graph solver here or the JuliaManifolds ecosystem. If we stray but a little, we are going to get these impossible error stacks and funky numerics and then trying to debug will be a nightmare. |
For the notation – sure I am not saying you must change it, just if you could mention that the notation is different in Manifolds.jl or something. An also for the update – suer, we still need a few more iterations to finish the Manifolds.jl release – Manopt is already done for example – but Manifolds.jl has just a few small errors to fix left. |
Nice!
I have two short comments after a short first look: In the intro you introduce Lie groups – at the end you link to JuliaManifolds/Manifolds.jl, but you could actually link to the documentation about GroupManifolds? https://juliamanifolds.github.io/Manifolds.jl/latest/manifolds/group.html
Second, more e technical remark: We redesigned ManifoldsBase to have a neat trait system, so
AbstractGroupManifold
will vanish in the next (breaking) release of Manifolds.jl (based on the already released ManifoldsBase.jl 0.13.0 with its own documentation now) and there will just be aIsGroupManifold
trait.Oh I just saw two further things down the road:
Originally posted by @kellertuer in JuliaManifolds/Manifolds.jl#355 (comment)
The text was updated successfully, but these errors were encountered: