Type-assert vconvert
s to circumvent inference restriction on recursion
#109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaSIMD/LoopVectorization.jl#526, building upon @chriselrod's last commits a month or two ago, by type-asserting the return types of
vconvert
in the relevant cases.Digging around with Cthuhlu's
@descend
I found that the issue, at least when I tested on 1.10.2, originates from the recursive calling of_vconvert
inpromote
which caused the compiler to give up on inference (I assume this became more restrictive in 1.10).Not sure if this solution is "legal" in the sense that
vconvert
always returns the type I annotated.If this is fine, I would also add tests in LV's "test/" directory.