Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix number of purity args on 1.11+ #115

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

KristofferC
Copy link
Contributor

Fixes #114.

src/llvm_types.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new effects need to be tightened (as suggested) before this will be foldable, but LGTM 👍

Thanks!

KristofferC and others added 2 commits October 14, 2024 14:26
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
@chriselrod chriselrod disabled auto-merge October 14, 2024 13:22
@chriselrod chriselrod merged commit 1ad67ab into JuliaSIMD:master Oct 14, 2024
4 of 20 checks passed
@topolarity
Copy link
Contributor

Thanks @chriselrod !

@chriselrod
Copy link
Member

chriselrod commented Oct 14, 2024

No problem!

The auto-merge won't work while tests are failing.

There were unfortunately some regressions that I never got around to looking at.
I'd suggest either

  1. Override to ignore branch protection and merge anyway.
  2. Fix those tests...
  3. Turn off the tests?

As of Julia 1.12, the tools will exist to drop RecursiveFactorization (and thus the JuliaSIMD ecosystem) from the SciML ecosystem by open sourcing a certain package (that requires LLVM17 for replacing RF), so folks will have to consider cost/benefit in the approach you take for getting important packages running on Julia >= 1.12.
At the very least, I'd consider the possibility of doing that, to encourage users of JuliaSIMD to pay for support if they want support, rather than take it for granted.
If it isn't important enough for anyone to be willing to pay for it, why bother spending time on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong number of args to Expr(:purity, ...)
3 participants