Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare error exception or throw warning instead of just using error() #71

Open
jolars opened this issue May 12, 2022 · 0 comments
Open

Declare error exception or throw warning instead of just using error() #71

jolars opened this issue May 12, 2022 · 0 comments

Comments

@jolars
Copy link
Contributor

jolars commented May 12, 2022

Consider this line:

Lasso.jl/src/coordinate_descent.jl

Line 619 in ea74151

error("coordinate descent failed to converge in $maxiter iterations at λ = $λ")

It would be much better and more kosher to use throw() along with a proper exception.

As an alternative, which I actually think makes more sense, you could just throw a warning instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jolars